You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/17 04:26:42 UTC

[GitHub] [shardingsphere] wgy8283335 opened a new issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

wgy8283335 opened a new issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059


   Target
   - Collate SQL definition of DROP TABLE to make SQL definition of Apache ShardingSphere the same with Oracle's.
   - Add a test case
   
   HOW
   1 Compare DROP TABLE definition in Oficial SQL Doc and ShardingSphere SQL Doc
   2 If there is any difference in ShardingSphere SQL Doc, please correct them referring to Official SQL Doc (g4 file of ANTLR)
   3 Run mvn install shardingsphere-sql-parser-oracle
   4 Check whether there are any exceptions. If exists, please fix them. (Please pay attention to xxxVisitor.class)
   5 Add new corresponding SQL case in shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql and expected parsed result in shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/case
   6 Run SQLParserParameterizedTest (shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/SQLParserParameterizedTest.java).
   
   Tips
   - Since this issue is a child one of #6480, I guess the PRs relevant to #6480 will give you some examples or hints.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 closed issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

Posted by GitBox <gi...@apache.org>.
wgy8283335 closed issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 closed issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

Posted by GitBox <gi...@apache.org>.
wgy8283335 closed issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 closed issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

Posted by GitBox <gi...@apache.org>.
wgy8283335 closed issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059#issuecomment-762214675


   Hi, I would like to work on this issue. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #9059: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #9059:
URL: https://github.com/apache/shardingsphere/issues/9059#issuecomment-762144935


   Hi @wgy8283335 
   
   > Compare DROP TABLE definition in Oficial SQL Doc and ShardingSphere SQL Doc
   
   Could you point the specific links for `DROP TABLE definition` and `ShardingSphere SQL Doc`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org