You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/05 11:45:29 UTC

[GitHub] [flink] GJL commented on a change in pull request #10080: [FLINK-14600] Degenerate the current AtomicInteger type of verticesFinished to a normal int type

GJL commented on a change in pull request #10080: [FLINK-14600] Degenerate the current AtomicInteger type of verticesFinished to a normal int type
URL: https://github.com/apache/flink/pull/10080#discussion_r342498395
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ##########
 @@ -1381,8 +1380,7 @@ private void initFailureCause(Throwable t) {
 	 */
 	void vertexFinished() {
 		assertRunningInJobMasterMainThread();
-		final int numFinished = verticesFinished.incrementAndGet();
 
 Review comment:
   I would keep this variable for readability. `++` can be easily missed in the if-condition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services