[GitHub] [iceberg] rajarshisarkar commented on a diff in pull request #4903: Spark: Use options as a CaseSensitiveMap

[GitBox <gi...@apache.org>]

rajarshisarkar commented on code in PR #4903:
URL: https://github.com/apache/iceberg/pull/4903#discussion_r886753609


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -119,7 +119,7 @@ public class SparkCatalog extends BaseCatalog {
   protected Catalog buildIcebergCatalog(String name, CaseInsensitiveStringMap options) {
     Configuration conf = SparkUtil.hadoopConfCatalogOverrides(SparkSession.active(), name);
     Map<String, String> optionsMap = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
-    optionsMap.putAll(options);
+    optionsMap.putAll(options.asCaseSensitiveMap());

Review Comment:
   This is needed to save case sensitive [S3 write/delete tag keys](https://github.com/apache/iceberg/blob/master/docs/integrations/aws.md#s3-tags) for objects.
   
   There is a thread in `general` channel on this, let me add you there: https://apache-iceberg.slack.com/archives/C025PH0G1D4/p1653879105452189
   
   I have removed the case insensitive comparator from the Treemap as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org