[airflow] branch master updated: Update `SimpleHttpOperator` to take auth object (#15605)

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ash pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/master by this push:
     new f122e28  Update `SimpleHttpOperator` to take auth object (#15605)
f122e28 is described below

commit f122e2826d6415340c6f8f96cc53044a2395c1e7
Author: Fred Thomsen <me...@fredthomsen.net>
AuthorDate: Mon May 10 07:25:54 2021 -0400

    Update `SimpleHttpOperator` to take auth object (#15605)
    
    A `requests.auth.AuthBase` object is not passed through from the
    `SimpleHttpOperator` to the underlying `HttpHook`, thus if you want to
    use the `SimpleHttpOperator` but have a custom auth_type, you must
    inherit from it and override the execute method.  Update the operator
    to take this parameter.
---
 airflow/providers/http/operators/http.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/airflow/providers/http/operators/http.py b/airflow/providers/http/operators/http.py
index 457b94d..b629518 100644
--- a/airflow/providers/http/operators/http.py
+++ b/airflow/providers/http/operators/http.py
@@ -15,7 +15,9 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from typing import Any, Callable, Dict, Optional
+from typing import Any, Callable, Dict, Optional, Type
+
+from requests.auth import AuthBase, HTTPBasicAuth
 
 from airflow.exceptions import AirflowException
 from airflow.models import BaseOperator
@@ -59,6 +61,8 @@ class SimpleHttpOperator(BaseOperator):
         depends on the option that's being modified.
     :param log_response: Log the response (default: False)
     :type log_response: bool
+    :param auth_type: The auth type for the service
+    :type auth_type: AuthBase of python requests lib
     """
 
     template_fields = [
@@ -82,6 +86,7 @@ class SimpleHttpOperator(BaseOperator):
         extra_options: Optional[Dict[str, Any]] = None,
         http_conn_id: str = 'http_default',
         log_response: bool = False,
+        auth_type: Type[AuthBase] = HTTPBasicAuth,
         **kwargs: Any,
     ) -> None:
         super().__init__(**kwargs)
@@ -94,13 +99,14 @@ class SimpleHttpOperator(BaseOperator):
         self.response_filter = response_filter
         self.extra_options = extra_options or {}
         self.log_response = log_response
+        self.auth_type = auth_type
         if kwargs.get('xcom_push') is not None:
             raise AirflowException("'xcom_push' was deprecated, use 'BaseOperator.do_xcom_push' instead")
 
     def execute(self, context: Dict[str, Any]) -> Any:
         from airflow.utils.operator_helpers import make_kwargs_callable
 
-        http = HttpHook(self.method, http_conn_id=self.http_conn_id)
+        http = HttpHook(self.method, http_conn_id=self.http_conn_id, auth_type=self.auth_type)
 
         self.log.info("Calling HTTP method")