You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Cristian Tarsoaga (JIRA)" <ji...@apache.org> on 2015/12/16 23:55:46 UTC
[jira] [Updated] (THRIFT-3493) [fix] libthrift does not compile on
windows using visual studio
[ https://issues.apache.org/jira/browse/THRIFT-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cristian Tarsoaga updated THRIFT-3493:
--------------------------------------
Description:
1. Thrift.cpp should also be removed from the vcxproj file, this is not used anymore, causes compile time error.
2. Missing TProtocol.cpp and TOutput.cpp from libthrift.vcxproj results in linker errors.
see pull request on github
was:
diff --git a/lib/cpp/libthrift.vcxproj b/lib/cpp/libthrift.vcxproj
index b4f1c50..4feb1d7 100644
--- a/lib/cpp/libthrift.vcxproj
+++ b/lib/cpp/libthrift.vcxproj
@@ -1,4 +1,4 @@
-?<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug-mt|Win32">
@@ -47,12 +47,13 @@
<ClCompile Include="src\thrift\protocol\TBase64Utils.cpp" />
<ClCompile Include="src\thrift\protocol\TDebugProtocol.cpp"/>
<ClCompile Include="src\thrift\protocol\TJSONProtocol.cpp"/>
+ <ClCompile Include="src\thrift\protocol\TProtocol.cpp"/>
<ClCompile Include="src\thrift\protocol\TMultiplexedProtocol.cpp"/>
<ClCompile Include="src\thrift\server\TSimpleServer.cpp"/>
<ClCompile Include="src\thrift\server\TThreadPoolServer.cpp"/>
<ClCompile Include="src\thrift\server\TThreadedServer.cpp"/>
<ClCompile Include="src\thrift\TApplicationException.cpp"/>
- <ClCompile Include="src\thrift\Thrift.cpp"/>
+ <ClCompile Include="src\thrift\TOutput.cpp"/>
<ClCompile Include="src\thrift\transport\TBufferTransports.cpp"/>
<ClCompile Include="src\thrift\transport\TFDTransport.cpp" />
<ClCompile Include="src\thrift\transport\THttpClient.cpp" />
@@ -93,6 +94,7 @@
<ClInclude Include="src\thrift\server\TThreadedServer.h" />
<ClInclude Include="src\thrift\TApplicationException.h" />
<ClInclude Include="src\thrift\Thrift.h" />
+ <ClInclude Include="src\thrift\TOutput.h" />
<ClInclude Include="src\thrift\TProcessor.h" />
<ClInclude Include="src\thrift\transport\TBufferTransports.h" />
<ClInclude Include="src\thrift\transport\TFDTransport.h" />
> [fix] libthrift does not compile on windows using visual studio
> ---------------------------------------------------------------
>
> Key: THRIFT-3493
> URL: https://issues.apache.org/jira/browse/THRIFT-3493
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Environment: windows
> visual studio
> Reporter: Cristian Tarsoaga
> Priority: Minor
> Labels: build-failure, patch, windows,
> Fix For: 0.9.4
>
>
> 1. Thrift.cpp should also be removed from the vcxproj file, this is not used anymore, causes compile time error.
> 2. Missing TProtocol.cpp and TOutput.cpp from libthrift.vcxproj results in linker errors.
> see pull request on github
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)