DO NOT REPLY [Bug 24506] - New line elimination at end of directives

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=24506>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24506





------- Additional Comments From tmp@kappia.com  2005-07-20 20:01 -------
(In reply to comment #3)
> trimSpaces removes any template text between two standard or custom actions only
> if the template text is all white spaces, and should not cause the space to be
> removed in your cases.  Supply a test case if you still have problems.

True, but trimSpaces is still far too eager for the following universal case:

${firstName} ${lastName} -> "bobsmith"

...which really is not what you want, and means the directive is effectively
useless. TrimSpaces should only remove NEWLINE characters NOT SPACES between two
directives (and hence should probably be renamed). It wouldnt be so bad for HTML
if it just normalized it down to one space: s/\s+\ /

This is also discussed here:
http://raibledesigns.com/comments/rd/sunsets/trim_spaces_in_your_jsp



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org