You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/20 13:08:49 UTC
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #14958: Add use SPI steps for proxy startup.
terrymanu commented on a change in pull request #14958:
URL: https://github.com/apache/shardingsphere/pull/14958#discussion_r788743254
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.cn.md
##########
@@ -45,6 +45,9 @@ weight = 1
当用户需要使用自定义的算法类时，可通过以下方式配置使用自定义算法，以分片为例：
1. 实现 `ShardingAlgorithm` 接口定义的算法实现类。
+1. 在项目 resources 目录下创建 META-INF/services 目录。
Review comment:
resources and META-INF/services should around with `, just keep consist with ShardingAlgorithm
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.en.md
##########
@@ -45,6 +45,9 @@ please refer to [Distributed Transaction](/en/user-manual/shardingsphere-jdbc/sp
When developer need to use user-defined algorithm, should use the way below to configure algorithm, use sharding algorithm as example.
1. Implement `ShardingAlgorithm` interface.
+1. Create META-INF/services directory in the resources directory.
+1. Create a new file org.apache.shardingsphere.sharding.spi.ShardingAlgorithm in the META-INF/services directory.
Review comment:
resources and META-INF/services should around with , just keep consist with ShardingAlgorithm`
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.cn.md
##########
@@ -45,6 +45,9 @@ weight = 1
当用户需要使用自定义的算法类时，可通过以下方式配置使用自定义算法，以分片为例：
1. 实现 `ShardingAlgorithm` 接口定义的算法实现类。
+1. 在项目 resources 目录下创建 META-INF/services 目录。
+1. 在 META-INF/services 目录下新建文件 org.apache.shardingsphere.sharding.spi.ShardingAlgorithm
+1. 将实现类的绝对路径写入至 文件 org.apache.shardingsphere.sharding.spi.ShardingAlgorithm
Review comment:
org.apache.shardingsphere.sharding.spi.ShardingAlgorithm should around `
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.cn.md
##########
@@ -45,6 +45,9 @@ weight = 1
当用户需要使用自定义的算法类时，可通过以下方式配置使用自定义算法，以分片为例：
1. 实现 `ShardingAlgorithm` 接口定义的算法实现类。
+1. 在项目 resources 目录下创建 META-INF/services 目录。
+1. 在 META-INF/services 目录下新建文件 org.apache.shardingsphere.sharding.spi.ShardingAlgorithm
Review comment:
META-INF/services and org.apache.shardingsphere.sharding.spi.ShardingAlgorithm should around `
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.en.md
##########
@@ -45,6 +45,9 @@ please refer to [Distributed Transaction](/en/user-manual/shardingsphere-jdbc/sp
When developer need to use user-defined algorithm, should use the way below to configure algorithm, use sharding algorithm as example.
1. Implement `ShardingAlgorithm` interface.
+1. Create META-INF/services directory in the resources directory.
Review comment:
resources and META-INF/services should around with `
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.cn.md
##########
@@ -45,6 +45,9 @@ weight = 1
当用户需要使用自定义的算法类时，可通过以下方式配置使用自定义算法，以分片为例：
1. 实现 `ShardingAlgorithm` 接口定义的算法实现类。
+1. 在项目 resources 目录下创建 META-INF/services 目录。
+1. 在 META-INF/services 目录下新建文件 org.apache.shardingsphere.sharding.spi.ShardingAlgorithm
+1. 将实现类的绝对路径写入至 文件 org.apache.shardingsphere.sharding.spi.ShardingAlgorithm
Review comment:
Please remove useless space between `至` and `文件`
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/startup/bin.en.md
##########
@@ -45,6 +45,9 @@ please refer to [Distributed Transaction](/en/user-manual/shardingsphere-jdbc/sp
When developer need to use user-defined algorithm, should use the way below to configure algorithm, use sharding algorithm as example.
1. Implement `ShardingAlgorithm` interface.
+1. Create META-INF/services directory in the resources directory.
+1. Create a new file org.apache.shardingsphere.sharding.spi.ShardingAlgorithm in the META-INF/services directory.
+1. Absolute path of the implementation class are write to the file org.apache.shardingsphere.sharding.spi.ShardingAlgorithm
Review comment:
org.apache.shardingsphere.sharding.spi.ShardingAlgorithm should around `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org