You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2014/11/25 09:50:14 UTC

[Bug 57253] DirectoryScanner holds on to too many strings

https://issues.apache.org/bugzilla/show_bug.cgi?id=57253

--- Comment #1 from Stefan Bodewig <bo...@apache.org> ---
It's not quite fair to ask me to explain a code change I've created more than
eleven years ago ;-)

Looking through my archives this was the first time we tried various options
speeding up DirectoryScanner - this has been long before we introduced
TokenizedPath/Pattern.  It is quite possible later changes rendered the
hasBeenScanned test redundant.  I'll perform some experiments.

Note getScannedDirs is used by a test (and nothing else AFAICT), so if you
wanted to remove the extra check, this will need to be adapted.

I haven't thought through all the reasons we keep the structures you mention,
will do so later today, just wanted to provide an early feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.