You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/08/30 00:00:10 UTC
[jira] [Created] (HBASE-6689) HRegion.increment comment nits
Gregory Chanan created HBASE-6689:
-------------------------------------
Summary: HRegion.increment comment nits
Key: HBASE-6689
URL: https://issues.apache.org/jira/browse/HBASE-6689
Project: HBase
Issue Type: Improvement
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Trivial
Fix For: 0.96.0
Just a couple of trivial nits with the comments in this area of code:
- In the test, a thread is called reader when it never actually reads, just flushes
- The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6689) HRegion.increment comment nits
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445612#comment-13445612 ]
Hudson commented on HBASE-6689:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #155 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/155/])
HBASE-6689 HRegion.increment comment nits (Revision 1379152)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6689) HRegion.increment comment nits
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6689:
-------------------------
Hadoop Flags: Reviewed
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6689) HRegion.increment comment nits
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6689:
----------------------------------
Status: Patch Available (was: Open)
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6689) HRegion.increment comment nits
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444514#comment-13444514 ]
Hadoop QA commented on HBASE-6689:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542998/HBASE-6689.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 110 warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2728//console
This message is automatically generated.
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6689) HRegion.increment comment nits
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6689:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Gregory
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6689) HRegion.increment comment nits
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445267#comment-13445267 ]
Gregory Chanan commented on HBASE-6689:
---------------------------------------
Test failure is unrelated.
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6689) HRegion.increment comment nits
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444473#comment-13444473 ]
stack commented on HBASE-6689:
------------------------------
+1 on patch
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6689) HRegion.increment comment nits
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6689:
----------------------------------
Attachment: HBASE-6689.patch
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked. But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira