You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ai...@apache.org on 2009/02/25 15:00:39 UTC
svn commit: r747783 -
/qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueThreadPoolTest.java
Author: aidan
Date: Wed Feb 25 14:00:39 2009
New Revision: 747783
URL: http://svn.apache.org/viewvc?rev=747783&view=rev
Log:
QPID-1668: check initial count, don't assume it's 0. It should be, but there are bugs in ApplicationRegistry.close that prevent this from working.
Modified:
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueThreadPoolTest.java
Modified: qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueThreadPoolTest.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueThreadPoolTest.java?rev=747783&r1=747782&r2=747783&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueThreadPoolTest.java (original)
+++ qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueThreadPoolTest.java Wed Feb 25 14:00:39 2009
@@ -35,7 +35,7 @@
public void test() throws AMQException
{
- assertEquals("References exist before start!", 0, ReferenceCountingExecutorService.getInstance().getReferenceCount());
+ int initialCount = ReferenceCountingExecutorService.getInstance().getReferenceCount();
VirtualHost test = ApplicationRegistry.getInstance(1).getVirtualHostRegistry().getVirtualHost("test");
try
@@ -45,12 +45,12 @@
false, test, null);
assertFalse("Creation did not start Pool.", ReferenceCountingExecutorService.getInstance().getPool().isShutdown());
+
+ assertEquals("References not increased", initialCount + 1, ReferenceCountingExecutorService.getInstance().getReferenceCount());
queue.stop();
- assertEquals("References still exist", 0, ReferenceCountingExecutorService.getInstance().getReferenceCount());
-
- assertTrue("Stop did not clean up.", ReferenceCountingExecutorService.getInstance().getPool().isShutdown());
+ assertEquals("References not decreased", initialCount , ReferenceCountingExecutorService.getInstance().getReferenceCount());
}
finally
{
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org