[GitHub] [solr] gerlowskija commented on pull request #570: Move all '*Payload' classes inside their API counterparts

[GitBox <gi...@apache.org>]

gerlowskija commented on pull request #570:
URL: https://github.com/apache/solr/pull/570#issuecomment-1023210384


   FYI @madrob - here's the refactor of those 'Payload' classes, as requested.
   
   There's still a few beans missing from this PR.  A few (Package, PluginMeta) were named and used a little differently than I'm used to, and I hope to get to them when I get a bit more time.
   
   Two others (DeleteBackupPayload, ListBackupPayload) are already used to implement SolrRequest classes in SolrJ (the eventual other use of these payload classes that I mentioned [here](https://github.com/apache/solr/pull/565#issuecomment-1021504830) and [here](https://issues.apache.org/jira/browse/SOLR-15187).)  I must've done these two as models when adding them in SIP-12 and forgotten about it.  Anyway I _don't_ plan on moving these under their API counterparts, as it'd require undoing the SolrRequest implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org