[GitHub] gianm commented on a change in pull request #6095: Add support 'keepSegmentGranularity' for compactionTask

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6095: Add support 'keepSegmentGranularity' for compactionTask
URL: https://github.com/apache/incubator-druid/pull/6095#discussion_r207743646
 
 

 ##########
 File path: server/src/main/java/io/druid/server/coordinator/helper/DruidCoordinatorSegmentCompactor.java
 ##########
 @@ -150,8 +150,11 @@ private CoordinatorStats doRun(
 
       if (segmentsToCompact.size() > 1) {
         final DataSourceCompactionConfig config = compactionConfigs.get(dataSourceName);
+        // Currently set keepSegmentGranularity to false because it breaks the algorithm of CompactionSegmentIterator to
 
 Review comment:
   Do you plan to address this in a future patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org