[jira] [Commented] (RAVE-711) Shared page is rendered before the user accepts the page

["Paul Sharples (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RAVE-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448674#comment-13448674 ] 

Paul Sharples commented on RAVE-711:
------------------------------------

I took the liberty to update Daniels patch (v3) and update it slightly so that instead of using dialog boxes, the "accept/decline" status is now rendered on the actual page itself.  Originally my rationale for using the dialog box was so that a user could either click "accept" to accept the share, "decline" to refuse the share or "cancel", which would allow the page to be rendered and the user could see the page (but the next time they clicked on it, the dialog would once again appear).  However, as a user can still click "remove share" in the page menu after they have previously clicked "accept", I dont think it makes any sense to use a dialog box now.
                
> Shared page is rendered before the user accepts the page
> --------------------------------------------------------
>
>                 Key: RAVE-711
>                 URL: https://issues.apache.org/jira/browse/RAVE-711
>             Project: Rave
>          Issue Type: Bug
>    Affects Versions: 0.12
>            Reporter: Jasha Joachimsthal
>            Assignee: Paul Sharples
>         Attachments: fixPageRenderingBeforeAcceptingShare(Rave-711)-2.patch, fixPageRenderingBeforeAcceptingShare(Rave-711)-3.patch, fixPageRenderingBeforeAcceptingShare(Rave-711).patch
>
>
> Canonical shares page with john.doe
> john.doe clicks on shared page
> Shared page is rendered before john.doe has accepted or declined the page

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira