[GitHub] [bookkeeper] TakaHiR07 commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger

["TakaHiR07 (via GitHub)" <gi...@apache.org>]

TakaHiR07 commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1568016598

   > > Now my solution is also repair the opened ledger, and ensure not write the opened ledger by do not modify the topic metadata.
   > 
   > Could you please tell me how you implemented it? Now we check the ledger placement policy when its metadata is closed. Did you change the source code to implement it?
   > 
   > https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
   
   I change two part of source code, remove "if (!metadata.isClosed())"
   
   https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
   
   https://github.com/lordcheng10/bookkeeper/blob/8309b1895c240a7fba8719cacf551b2cc4abda42/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L391


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org