[jira] [Resolved] (WICKET-4971) AtmosphereEventSubscriptionCollector is slow

["Emond Papegaaij (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij resolved WICKET-4971.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 6.5.0

Subscription collection is now cached, thanks for the suggestion! Wicket itself does not use Guava, but wicket-atmosphere does.
                
> AtmosphereEventSubscriptionCollector is slow
> --------------------------------------------
>
>                 Key: WICKET-4971
>                 URL: https://issues.apache.org/jira/browse/WICKET-4971
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-atmosphere
>            Reporter: Andrei Badea
>            Assignee: Emond Papegaaij
>             Fix For: 6.5.0
>
>
> AtmosphereEventSubscriptionCollector.onBeforeRender() is called so often that the amount of work it performs starts being significant. The method was a hotspot in our performance tests. I reduced the average HTTP response time by 20ms by caching the subscribe metods:
>     private static final ConcurrentMap<Class<?>, List<Method>> class2SubscribeMethod = new ConcurrentHashMap<Class<?>, List<Method>>();
>     @Override
>     public void onBeforeRender(Component component)
>     {
>         for (Method curMethod : getSubscribeMethods(component.getClass()))
>         {
>             subscribeComponent(component, null, curMethod);
>         }
>         for (Behavior curBehavior : component.getBehaviors())
>         {
>             for (Method curMethod : getSubscribeMethods(curBehavior.getClass()))
>             {
>                 subscribeComponent(component, curBehavior, curMethod);
>             }
>         }
>     }
>     private List<Method> getSubscribeMethods(Class<?> clazz)
>     {
>         List<Method> methods = class2SubscribeMethod.get(clazz);
>         if (methods != null)
>         {
>             return methods;
>         }
>         methods = computeSubscribeMethods(clazz);
>         List<Method> newMethods = class2SubscribeMethod.putIfAbsent(clazz, methods);
>         return newMethods != null ? newMethods : methods;
>     }
>     private List<Method> computeSubscribeMethods(Class<?> clazz)
>     {
>         List<Method> result = Lists.newArrayList();
>         for (Method curMethod : clazz.getMethods())
>         {
>             if (curMethod.isAnnotationPresent(Subscribe.class))
>             {
>                 verifyMethodParameters(curMethod);
>                 result.add(curMethod);
>             }
>         }
>         return result;
>     }
> I can provide a patch of a pull request if needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira