[jira] Commented: (CASSANDRA-631) possible NPE in StorageProxy?

["gabriele renzi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789733#action_12789733 ] 

gabriele renzi commented on CASSANDRA-631:
------------------------------------------

forgot to say: with both patches I have a tet failure 

    [junit] Testcase: testImportSuperCf(org.apache.cassandra.tools.SSTableImportTest):	Caused an ERROR
    [junit] Invalid localDeleteTime read: -2099059532
    [junit] java.io.IOException: Invalid localDeleteTime read: -2099059532
    [junit] 	at org.apache.cassandra.db.SuperColumnSerializer.deserialize(SuperColumn.java:368)
    [junit] 	at org.apache.cassandra.db.SuperColumnSerializer.deserialize(SuperColumn.java:1)
    [junit] 	at org.apache.cassandra.db.filter.SSTableNamesIterator.<init>(SSTableNamesIterator.java:103)
    [junit] 	at org.apache.cassandra.db.filter.NamesQueryFilter.getSSTableColumnIterator(NamesQueryFilter.java:69)
    [junit] 	at org.apache.cassandra.tools.SSTableImportTest.testImportSuperCf(SSTableImportTest.java:63)

at r889834 I also see it without the patches though :)

> possible NPE in StorageProxy?
> -----------------------------
>
>                 Key: CASSANDRA-631
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-631
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.5
>         Environment: all
>            Reporter: gabriele renzi
>         Attachments: CASSANDRA-631-big.patch, CASSANDRA-631-tiny.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> insert() in StorageProxy contains a logging statement that refers to a possibly un-initialized variable
> {{{
> logger.debug("insert writing key " + rm.key() + " to " + unhintedMessage.getMessageId() + "@" + hintedTarget + " for " + target);
> }}}
> this could happen if getHintedEndpointMap(rm.key(), naturalEndpoints) returns only elements for which target.equals(hintedTarget) returns false, which seems possible to me. 
> Looking at the code I get the feeling the reference should probably be to 'hintedMessage', instead of "unhintedMessage", if not so an 
> assert statement could be appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.