You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "petern48 (via GitHub)" <gi...@apache.org> on 2025/07/28 17:41:32 UTC

[PR] [GH-1755] Implement ST_Segmentize function [sedona]

petern48 opened a new pull request, #2179:
URL: https://github.com/apache/sedona/pull/2179

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #1755
   
   ## What changes were proposed in this PR?
   Implement ST_Segmentize for spark, flink, snowflake
   
   ## How was this patch tested?
   Added tests
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1755] Implement ST_Segmentize function and geopandas.segmentize() [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2179:
URL: https://github.com/apache/sedona/pull/2179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1755] Implement ST_Segmentize function [sedona]

Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on code in PR #2179:
URL: https://github.com/apache/sedona/pull/2179#discussion_r2237567142


##########
common/src/main/java/org/apache/sedona/common/Functions.java:
##########
@@ -1872,6 +1873,13 @@ public static Geometry[] subDivide(Geometry geometry, int maxVertices) {
     return GeometrySubDivider.subDivide(geometry, maxVertices);
   }
 
+  public static Geometry segmentize(Geometry geometry, double maxSegmentLength) {
+    if (maxSegmentLength <= 0) {
+      throw new IllegalArgumentException("maxSegmentLength must be greater than 0");
+    }
+    return Densifier.densify(geometry, maxSegmentLength);

Review Comment:
   :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1755] Implement ST_Segmentize function [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #2179:
URL: https://github.com/apache/sedona/pull/2179#discussion_r2237600673


##########
docs/api/flink/Function.md:
##########
@@ -4095,6 +4095,41 @@ Output:
 ]
 ```
 
+## ST_Segmentize

Review Comment:
   The docs should be sorted alphabetically.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org