You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/03/11 19:18:28 UTC
Review Request 70186: Updated protobuf comments related to operation
feedback.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Gastón Kleiman.
Repository: mesos
Description
-------
While the `id` field in `Offer::Operation` was previously marked
experimental, it is also wise to explicitly mark the related
scheduler API calls and events as experimental to avoid any
confusion.
Diffs
-----
include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb
include/mesos/scheduler/scheduler.proto 27634153b372584a214c9631a939254bd984c735
include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3
include/mesos/v1/scheduler/scheduler.proto 9b0f54604f5b7b904b52b7f0a24c3a6402659ef0
Diff: https://reviews.apache.org/r/70186/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 70186: Updated protobuf comments related to
operation feedback.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/#review213610
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70186]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 11, 2019, 7:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70186/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 7:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `id` field in `Offer::Operation` was previously marked
> experimental, it is also wise to explicitly mark the related
> scheduler API calls and events as experimental to avoid any
> confusion.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb
> include/mesos/scheduler/scheduler.proto 27634153b372584a214c9631a939254bd984c735
> include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3
> include/mesos/v1/scheduler/scheduler.proto 9b0f54604f5b7b904b52b7f0a24c3a6402659ef0
>
>
> Diff: https://reviews.apache.org/r/70186/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70186: Updated protobuf comments related to
operation feedback.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/#review213626
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On March 11, 2019, 12:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70186/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 12:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `id` field in `Offer::Operation` was previously marked
> experimental, it is also wise to explicitly mark the related
> scheduler API calls and events as experimental to avoid any
> confusion.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb
> include/mesos/scheduler/scheduler.proto 27634153b372584a214c9631a939254bd984c735
> include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3
> include/mesos/v1/scheduler/scheduler.proto 9b0f54604f5b7b904b52b7f0a24c3a6402659ef0
>
>
> Diff: https://reviews.apache.org/r/70186/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70186: Updated protobuf comments related to
operation feedback.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/#review213674
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70186`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2934/mesos-review-70186
Relevant logs:
- [apply-review-70186.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2934/mesos-review-70186/logs/apply-review-70186.log):
```
error: patch failed: include/mesos/mesos.proto:2124
error: include/mesos/mesos.proto: patch does not apply
error: patch failed: include/mesos/scheduler/scheduler.proto:130
error: include/mesos/scheduler/scheduler.proto: patch does not apply
error: patch failed: include/mesos/v1/mesos.proto:2117
error: include/mesos/v1/mesos.proto: patch does not apply
error: patch failed: include/mesos/v1/scheduler/scheduler.proto:128
error: include/mesos/v1/scheduler/scheduler.proto: patch does not apply
```
- Mesos Reviewbot Windows
On March 11, 2019, 7:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70186/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 7:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `id` field in `Offer::Operation` was previously marked
> experimental, it is also wise to explicitly mark the related
> scheduler API calls and events as experimental to avoid any
> confusion.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb
> include/mesos/scheduler/scheduler.proto 27634153b372584a214c9631a939254bd984c735
> include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3
> include/mesos/v1/scheduler/scheduler.proto 9b0f54604f5b7b904b52b7f0a24c3a6402659ef0
>
>
> Diff: https://reviews.apache.org/r/70186/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70186: Updated protobuf comments related to
operation feedback.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/#review213633
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 11, 2019, 12:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70186/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 12:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While the `id` field in `Offer::Operation` was previously marked
> experimental, it is also wise to explicitly mark the related
> scheduler API calls and events as experimental to avoid any
> confusion.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb
> include/mesos/scheduler/scheduler.proto 27634153b372584a214c9631a939254bd984c735
> include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3
> include/mesos/v1/scheduler/scheduler.proto 9b0f54604f5b7b904b52b7f0a24c3a6402659ef0
>
>
> Diff: https://reviews.apache.org/r/70186/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>