Re: [PR] Migrate tests to insta [datafusion]

["jsai28 (via GitHub)" <gi...@apache.org>]

jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001376856


##########
datafusion/core/tests/parquet/custom_reader.rs:
##########
@@ -96,17 +97,15 @@ async fn route_data_access_ops_to_parquet_file_reader_factory() {
     let task_ctx = session_ctx.task_ctx();
     let read = collect(parquet_exec, task_ctx).await.unwrap();
 
-    let expected = [
-        "+-----+----+----+",
-        "| c1  | c2 | c3 |",
-        "+-----+----+----+",
-        "| Foo | 1  | 10 |",
-        "|     | 2  | 20 |",
-        "| bar |    |    |",
-        "+-----+----+----+",
-    ];
-
-    assert_batches_sorted_eq!(expected, &read);
+    assert_snapshot!(batches_to_sort_string(&read), @r"

Review Comment:
   double check this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org