You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/02 13:43:57 UTC

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

franz1981 opened a new pull request #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968
 
 
   This reverts commit 9fe17d40

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581482362
 
 
   I see lots of this when running the testsuite:
   
   
   ```
   [Thread-3 (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=3c528f5b-469b-11ea-a46e-e0d55e27b7f3-1090222535)] 10:39:03,467 WARN  [org.apache.activemq.artemis.core.server] AMQ222218: Server disconnecting: Error decoding buffer: java.lang.IllegalStateException: java.lang.IllegalStateException: Error. Unable to instantiate FederationPolicy: org.apache.activemq.artemis.core.config.federation.FederationAddressPolicyConfiguration.<init>(null)
   	at org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:390) [:]
   	at org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl$DelegatingBufferHandler.bufferReceived(RemotingServiceImpl.java:654) [:]
   	at org.apache.activemq.artemis.core.remoting.impl.invm.InVMConnection$1.run(InVMConnection.java:204) [:]
   	at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) [:]
   	at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) [:]
   	at org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) [:]
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [rt.jar:1.8.0_151]
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [rt.jar:1.8.0_151]
   	at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [:2.12.0-SNAPSHOT]
   Caused by: java.lang.IllegalStateException: Error. Unable to instantiate FederationPolicy: org.apache.activemq.artemis.core.config.federation.FederationAddressPolicyConfiguration.<init>(null)
   	at org.apache.activemq.artemis.core.protocol.core.impl.wireformat.FederationStreamConnectMessage.getFederationPolicy(FederationStreamConnectMessage.java:153) [:]
   	at org.apache.activemq.artemis.core.protocol.core.impl.wireformat.FederationStreamConnectMessage.decodeRest(FederationStreamConnectMessage.java:131) [:]
   	at org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.decode(PacketImpl.java:364) [:]
   	at org.apache.activemq.artemis.core.protocol.ServerPacketDecoder.slowPathDecode(ServerPacketDecoder.java:266) [:]
   	at org.apache.activemq.artemis.core.protocol.ServerPacketDecoder.decode(ServerPacketDecoder.java:138) [:]
   	at org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:377) [:]
   	... 8 more
   Caused by: java.lang.NoSuchMethodException: org.apache.activemq.artemis.core.config.federation.FederationAddressPolicyConfiguration.<init>(null)
   	at java.lang.Class.getConstructor0(Class.java:3082) [rt.jar:1.8.0_151]
   	at java.lang.Class.getConstructor(Class.java:1825) [rt.jar:1.8.0_151]
   	at org.apache.activemq.artemis.core.protocol.core.impl.wireformat.FederationStreamConnectMessage.getFederationPolicy(FederationStreamConnectMessage.java:151) [:]
   	... 13 more
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] sebthom commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
sebthom commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581548630
 
 
   @clebertsuconic I created a new PR https://github.com/apache/activemq-artemis/pull/2969

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581482464
 
 
   @cshannon ??

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] cshannon commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581488757
 
 
   @clebertsuconic - the reason the PR was opened was because of that error

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] cshannon edited a comment on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
cshannon edited a comment on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581489533
 
 
   @clebertsuconic - Also as pointed out in the other discussion, simply changing it to `Class<?>[] `should fix the issue instead of `Class<?>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] cshannon edited a comment on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
cshannon edited a comment on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581488757
 
 
   @clebertsuconic - the reason the PR for the revert was opened was because of that error

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581488168
 
 
   I will go ahead and merge this based on the discussions at #2960

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] franz1981 commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581153684
 
 
   Please don't merge it yet: we need to understand what's going on :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] asfgit closed pull request #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] cshannon commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581489533
 
 
   @clebertsuconic - Also as pointed out in the other discussion, simply changing it to Class<?>[] should fix the issue instead of Class<?>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2968: Revert "NO-JIRA Fix compiler warning in FederationStreamConnectMessage"
URL: https://github.com/apache/activemq-artemis/pull/2968#issuecomment-581499622
 
 
   @cshannon if you want to send a PR fixing...
   
   I would kindly ask to wait someone run the whole testsuite before merging it though? send the PR but keep it under review until the testsuiste is ran.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services