Re: [PR] Core: Adding same view version as part of a concurrent update shouldn't fail [iceberg]

["pvary (via GitHub)" <gi...@apache.org>]

pvary commented on code in PR #14997:
URL: https://github.com/apache/iceberg/pull/14997#discussion_r2676676138


##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -369,6 +380,7 @@ public Builder addSchema(Schema schema) {
     private int addSchemaInternal(Schema schema) {
       int newSchemaId = reuseOrCreateNewSchemaId(schema);
       if (schemasById.containsKey(newSchemaId)) {
+        this.lastSeenExistingSchemaId = newSchemaId;

Review Comment:
   I have some doubts around this. Namely, it might be that we have a view with a little bit more history:
   - View with S1 updated to
   - View with S2 later updated to
   - View with S1
   
   In this case it is not enough that we have some random old schema which is the same as the new one. We would like to be sure that the last valid schema for the view is the S1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org