You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/22 15:14:56 UTC

[GitHub] [airflow] potiuk opened a new pull request #13257: Limit Azure Batch as it breaks dependencies.

potiuk opened a new pull request #13257:
URL: https://github.com/apache/airflow/pull/13257


   Azure Batch introduces dependencies that break Azure Blob Storage.
   
   Until #12188 is solved at least we need to limit Azure Batch
   version.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749732001


   ```
   /usr/local/lib/python3.6/site-packages/snowflake/connector/azure_util.py:13: in <module>
       from azure.storage.blob import BlobServiceClient, ContentSettings, ExponentialRetry
   E   ImportError: cannot import name 'BlobServiceClient'
   ```
   😿


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-753413971


   It seems to me that this change is not needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749737420


   Quie likely indeed. Which means that we need #12188 even more


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749712765


   [The Workflow run](https://github.com/apache/airflow/actions/runs/438575447) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749733682


   yeah. Will take a loook tomorrow!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749620034


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749735812


   Looks like problem with latest update for snowflake-connector. 
   See: https://github.com/snowflakedb/snowflake-connector-python/compare/v2.3.6...v2.3.7#diff-a48934b46856625b65f754feb949321a226cb7f78e1e2597ead71eb72b8dbb28
   ![Screenshot 2020-12-22 at 20 29 54](https://user-images.githubusercontent.com/12058428/102926188-e1424f80-4494-11eb-8467-f8be9f98b861.png)
   ![Screenshot 2020-12-22 at 20 31 32](https://user-images.githubusercontent.com/12058428/102926192-e2737c80-4494-11eb-8c88-74cfbe45aed9.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-753417393


   Yep. It can be closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749591408


   cc: @ephraimbuddy 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #13257:
URL: https://github.com/apache/airflow/pull/13257


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #13257: Limit Azure Batch as it breaks dependencies.

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13257:
URL: https://github.com/apache/airflow/pull/13257#issuecomment-749738827


   I pushed a test build with a limited version of snowflake-connector-python: https://github.com/apache/airflow/pull/13195


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org