You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/09/24 09:30:04 UTC
[GitHub] [cordova] erisu edited a comment on issue #155: (improvement) Do not require the www-folder to detect a Cordova-based project.
erisu edited a comment on issue #155:
URL: https://github.com/apache/cordova/issues/155#issuecomment-698229173
In the case of using Cordova Electron platform, these two files do exist side-by-side at the platform level.
E.g.
```
cordovaTest/platforms/electron/www/config.xml
cordovaTest/platforms/electron/www/package.json
```
If someone ran a Cordova command within that folder, the `findCordovaRootUp` would return a false positive.
Also, the `package.json` file at that directory is not a copy of the Cordova's project `package.json`. That is the `package.json` for the Electron app.
It might be possible to verify that the `cordova` property does not exist as it exists in the Cordova project's `pacakge.json`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org