You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2012/02/18 02:58:05 UTC

[jira] [Created] (HDFS-2973) HA: re-enable NO_ACK optimization for block deletion

HA: re-enable NO_ACK optimization for block deletion
----------------------------------------------------

                 Key: HDFS-2973
                 URL: https://issues.apache.org/jira/browse/HDFS-2973
             Project: Hadoop HDFS
          Issue Type: Sub-task
          Components: ha, name-node
    Affects Versions: HA branch (HDFS-1623)
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


Currently in trunk, when a file is removed, the deletion request is sent to the DNs with a special NO_ACK flag to indicate that they don't need to ACK the deletion. The NN itself takes care of removing the blocks from the block map, so the deletion report would be redundant.
In the HA branch, we disabled this to fix a failure in TestSafeMode -- when the active NN issues a block deletion, and the standby hasn't read the edits yet, this test case expects that it would see the block deletions.
I don't see any actual compelling reasons for this. I think we can restore the optimization and modify the test to pass.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HDFS-2973) HA: re-enable NO_ACK optimization for block deletion

Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon resolved HDFS-2973.
-------------------------------

       Resolution: Fixed
    Fix Version/s: HA branch (HDFS-1623)
     Hadoop Flags: Reviewed

Committed to HA branch (ran unit tests on this the other day)
                
> HA: re-enable NO_ACK optimization for block deletion
> ----------------------------------------------------
>
>                 Key: HDFS-2973
>                 URL: https://issues.apache.org/jira/browse/HDFS-2973
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: HA branch (HDFS-1623)
>
>         Attachments: hdfs-2973.txt
>
>
> Currently in trunk, when a file is removed, the deletion request is sent to the DNs with a special NO_ACK flag to indicate that they don't need to ACK the deletion. The NN itself takes care of removing the blocks from the block map, so the deletion report would be redundant.
> In the HA branch, we disabled this to fix a failure in TestSafeMode -- when the active NN issues a block deletion, and the standby hasn't read the edits yet, this test case expects that it would see the block deletions.
> I don't see any actual compelling reasons for this. I think we can restore the optimization and modify the test to pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira