You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ad...@apache.org on 2013/09/28 01:15:35 UTC
git commit: [JCLOUDS-302] Remove unnecessary String construction in
HttpUtils
Updated Branches:
refs/heads/master 7290cc8ea -> 73464c387
[JCLOUDS-302] Remove unnecessary String construction in HttpUtils
Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/commit/73464c38
Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/tree/73464c38
Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/diff/73464c38
Branch: refs/heads/master
Commit: 73464c3877c4c2106ed22b5825228de752840793
Parents: 7290cc8
Author: Niraj Tolia <nt...@maginatics.com>
Authored: Fri Sep 27 10:36:20 2013 -0700
Committer: Adrian Cole <ad...@gmail.com>
Committed: Fri Sep 27 16:15:20 2013 -0700
----------------------------------------------------------------------
.../main/java/org/jclouds/http/HttpUtils.java | 30 ++++++++++----------
1 file changed, 15 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/73464c38/core/src/main/java/org/jclouds/http/HttpUtils.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/jclouds/http/HttpUtils.java b/core/src/main/java/org/jclouds/http/HttpUtils.java
index 38a06ab..592205a 100644
--- a/core/src/main/java/org/jclouds/http/HttpUtils.java
+++ b/core/src/main/java/org/jclouds/http/HttpUtils.java
@@ -225,36 +225,36 @@ public class HttpUtils {
public void checkRequestHasRequiredProperties(HttpRequest message) {
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull(CONTENT_TYPE) == null,
- "configuration error please use request.getPayload().getContentMetadata().setContentType(value) as opposed to adding a content type header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setContentType(value) as opposed to adding a content type header: %s",
+ message);
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull(CONTENT_LENGTH) == null,
- "configuration error please use request.getPayload().getContentMetadata().setContentLength(value) as opposed to adding a content length header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setContentLength(value) as opposed to adding a content length header: %s",
+ message);
checkArgument(
message.getPayload() == null || message.getPayload().getContentMetadata().getContentLength() != null
|| "chunked".equalsIgnoreCase(message.getFirstHeaderOrNull("Transfer-Encoding")),
- "either chunked encoding must be set on the http request or contentlength set on the payload: " + message);
+ "either chunked encoding must be set on the http request or contentlength set on the payload: %s", message);
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull("Content-MD5") == null,
- "configuration error please use request.getPayload().getContentMetadata().setContentMD5(value) as opposed to adding a content md5 header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setContentMD5(value) as opposed to adding a content md5 header: %s",
+ message);
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull("Content-Disposition") == null,
- "configuration error please use request.getPayload().getContentMetadata().setContentDisposition(value) as opposed to adding a content disposition header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setContentDisposition(value) as opposed to adding a content disposition header: %s",
+ message);
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull(CONTENT_ENCODING) == null,
- "configuration error please use request.getPayload().getContentMetadata().setContentEncoding(value) as opposed to adding a content encoding header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setContentEncoding(value) as opposed to adding a content encoding header: %s",
+ message);
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull(CONTENT_LANGUAGE) == null,
- "configuration error please use request.getPayload().getContentMetadata().setContentLanguage(value) as opposed to adding a content language header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setContentLanguage(value) as opposed to adding a content language header: %s",
+ message);
checkArgument(
message.getPayload() == null || message.getFirstHeaderOrNull(EXPIRES) == null,
- "configuration error please use request.getPayload().getContentMetadata().setExpires(value) as opposed to adding an expires header: "
- + message);
+ "configuration error please use request.getPayload().getContentMetadata().setExpires(value) as opposed to adding an expires header: %s",
+ message);
}
public static void releasePayload(HttpMessage from) {