You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/03 23:45:39 UTC

[GitHub] athanatos opened a new pull request #940: BookieProtoEncoding: remove unnecessary slice() call

athanatos opened a new pull request #940: BookieProtoEncoding: remove unnecessary slice() call
URL: https://github.com/apache/bookkeeper/pull/940
 
 
   The ByteBuf returned by slice() has the same refcount and
   underlying buffer, it simply has independent index marks.
   As far as I can tell, buffer isn't used after this point,
   so we can just pass it in.
   
   Signed-off-by: Samuel Just <sj...@salesforce.com>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services