You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/08 17:34:00 UTC

[jira] [Commented] (NIFI-4192) Issue with the MergeContent Processor when processing Avro files

    [ https://issues.apache.org/jira/browse/NIFI-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118697#comment-16118697 ] 

ASF GitHub Bot commented on NIFI-4192:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2067

    NIFI-4192: Add more Avro/metadata merge options to MergeContent

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4192

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2067
    
----
commit 76d0411a60cd6d8fd36867d9d4270630bde80400
Author: Matt Burgess <ma...@apache.org>
Date:   2017-08-08T17:32:17Z

    NIFI-4192: Add more Avro/metadata merge options to MergeContent

----


> Issue with the MergeContent Processor when processing Avro files
> ----------------------------------------------------------------
>
>                 Key: NIFI-4192
>                 URL: https://issues.apache.org/jira/browse/NIFI-4192
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> Currently the Avro Merge strategy in MergeContent requires that any key/value pairs in the Avro non-reserved metadata must match. This might have been done to support re-merging of split Avro files upstream, since the "fragment.*" capability was added afterward.
> Now that the fragment.* attributes are available to help merge a batch of flow files, the user should be able to select the Avro Metadata Strategy the same way as the Attribute Strategy, with the additional option of "Ignore if unmatched", which should be default to maintain currently functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)