You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2010/03/29 12:57:08 UTC

[jira] Created: (CAMEL-2596) Netty component - add features xml

Netty component - add features xml
----------------------------------

                 Key: CAMEL-2596
                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
             Project: Apache Camel
          Issue Type: Sub-task
            Reporter: Claus Ibsen
             Fix For: 2.3.0


Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-2596 started by Ashwin Karpe.

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe updated CAMEL-2596:
--------------------------------

    Attachment: netty-features-20100330.patch

Hi Claus,

Please find attached, a feature patch I have created to install camel-netty in Servicemix 4/Karaf.

I used the wrap:http URI to add additional JBoss and Google jars needed as constraints by JBoss Netty. All the necessary jars are under APL 2.0. 

Following your review, I will be happy to commit it to the camel source. Please let me know.

Cheers,

Ashwin...

P.S: I am creating a patch with the Servicemix project to add netty as a bundle in the Servicemix 4/Karaf code stream. I will add the link shortly.




> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100330.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe resolved CAMEL-2596.
---------------------------------

    Resolution: Fixed

Patch applied as revision r929586 

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100331.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58570#action_58570 ] 

Ashwin Karpe commented on CAMEL-2596:
-------------------------------------

Hi Claus,

Please find the link to the Servicemix project requesting the netty bundle patches to be applied.

https://issues.apache.org/activemq/browse/SMX4-514

Cheers,

Ashwin... 

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100330.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe updated CAMEL-2596:
--------------------------------

    Attachment: netty-features-20100331.patch

Hi Willem,

Please see the corrected patch that does not look to a Servicemix wrapped bundle or with links to other extraneous dependencies.

I will commit this fix since it is very straightforward and works as intended.

Cheers,

Ashwin...

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100331.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58583#action_58583 ] 

Ashwin Karpe commented on CAMEL-2596:
-------------------------------------

Willem,

Looks like the Servicemix patch has already been applied.  I will change the camel patch right away.

Cheers,

Ashwin...

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100330.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe updated CAMEL-2596:
--------------------------------

    Attachment:     (was: netty-features-20100330.patch)

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100331.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2596) Netty component - add features xml

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58571#action_58571 ] 

Willem Jiang commented on CAMEL-2596:
-------------------------------------

Hi Ashwin,

Netty is already a OSGi bundle, why do you want to  create a wrap bundle in ServiceMix.
As Netty's dependency of guicy , protocol buff, xnio is optional, I don't think we need to put them into the camel-netty feature.
BTW, Netty support lots of logging framework,  It's not necessary to include jboss log API into the camel-netty feature.


> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100330.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58581#action_58581 ] 

Ashwin Karpe commented on CAMEL-2596:
-------------------------------------

Hi Willem,

Oops. Good catch.. :)

I missed the fact that it is an OSGi bundle as I started down this road. I will put up a different patch and reverse the Servicemix issue... (SMX4-514).

Cheers,

Ashwin...

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>         Attachments: netty-features-20100330.patch
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-2596) Netty component - add features xml

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe reassigned CAMEL-2596:
-----------------------------------

    Assignee: Ashwin Karpe

> Netty component - add features xml
> ----------------------------------
>
>                 Key: CAMEL-2596
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2596
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: 2.3.0
>
>
> Add camel-netty to the karaf features.xml file so people can easily install it in SMX/Karaf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.