You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2013/12/07 00:12:45 UTC

[3/3] git commit: THRIFT-2282 Incorect code generated for some typedefs

THRIFT-2282 Incorect code generated for some typedefs

Patch: Jens Geyer


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/5b8e7708
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/5b8e7708
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/5b8e7708

Branch: refs/heads/master
Commit: 5b8e770864d0ebe85e7aee3cc29de04edf60a71d
Parents: 739032a
Author: Jens Geyer <je...@apache.org>
Authored: Sat Dec 7 00:10:31 2013 +0100
Committer: Jens Geyer <je...@apache.org>
Committed: Sat Dec 7 00:11:38 2013 +0100

----------------------------------------------------------------------
 compiler/cpp/src/generate/t_delphi_generator.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/5b8e7708/compiler/cpp/src/generate/t_delphi_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_delphi_generator.cc b/compiler/cpp/src/generate/t_delphi_generator.cc
index 954735a..1e6b3fe 100644
--- a/compiler/cpp/src/generate/t_delphi_generator.cc
+++ b/compiler/cpp/src/generate/t_delphi_generator.cc
@@ -603,13 +603,12 @@ void t_delphi_generator::generate_typedef(t_typedef* ttypedef) {
   indent(s_struct) << 
     type_name(ttypedef) << " = ";
 
-  bool container = type->is_list() || type->is_map() || type->is_set();
-
   // commented out: the benefit is not big enough to risk breaking existing code
+  //bool container = type->is_list() || type->is_map() || type->is_set();
   //if( ! container)
   //  s_struct << "type ";  //the "type A = type B" syntax leads to E2574 with generics
 
-  s_struct << type_name(ttypedef->get_type(), ! container) << ";" << endl <<
+  s_struct << type_name(ttypedef->get_type()) << ";" << endl <<
     endl;
   indent_down();