You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/01 02:48:16 UTC

[GitHub] [incubator-hudi] umehrot2 opened a new pull request #1475: [HUDI-426][WIP] Initial implementation for Bootstrapping data source

umehrot2 opened a new pull request #1475: [HUDI-426][WIP] Initial implementation for Bootstrapping data source
URL: https://github.com/apache/incubator-hudi/pull/1475
 
 
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hudi] umehrot2 commented on pull request #1475: [HUDI-426][WIP] Initial implementation for Bootstrapping data source

Posted by GitBox <gi...@apache.org>.
umehrot2 commented on pull request #1475:
URL: https://github.com/apache/hudi/pull/1475#issuecomment-638522351


   Closing this pull request, in favor of the new pull request https://github.com/apache/hudi/pull/1702 where I have consolidated all the datasource related changes in one PR for review. It includes this read datasource part as well. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] umehrot2 closed pull request #1475: [HUDI-426][WIP] Initial implementation for Bootstrapping data source

Posted by GitBox <gi...@apache.org>.
umehrot2 closed pull request #1475:
URL: https://github.com/apache/hudi/pull/1475


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hudi] umehrot2 commented on issue #1475: [HUDI-426][WIP] Initial implementation for Bootstrapping data source

Posted by GitBox <gi...@apache.org>.
umehrot2 commented on issue #1475: [HUDI-426][WIP] Initial implementation for Bootstrapping data source
URL: https://github.com/apache/incubator-hudi/pull/1475#issuecomment-606998860
 
 
   @bvaradar if you glance through my implementation one thing I might require from you is that in `HoodieBaseFile` if we can store `FileStatus` for external data file instead of just the string path. I need the list of `FileStatus` of external data files to work with here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services