[GitHub] [trafficserver] ywkaras commented on a diff in pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

[GitBox <gi...@apache.org>]

ywkaras commented on code in PR #8643:
URL: https://github.com/apache/trafficserver/pull/8643#discussion_r891680748


##########
include/tscpp/api/Cleanup.h:
##########
@@ -124,9 +124,13 @@ class TxnAuxDataMgrBase
 
 using TxnAuxMgrData = TxnAuxDataMgrBase::MgrData;
 
-// Class to manage auxiliary data for a transaction.  If an instance is created for the transaction, the instance
-// will be deleted on the TXN_CLOSE transaction hook (which is always triggered for all transactions).
-// The TxnAuxData class must have a public default constructor.
+// Class to manage auxiliary data for a transaction.  If an instance of auxiliary data is created for the
+// transaction, the instance will be deleted on the TXN_CLOSE transaction hook (which is always triggered
+// for all transactions).  The TxnAuxData class must have a public default constructor.
+//
+// This class and the base class are pseudo-namespaces, have only static member functions (no data members).
+// The manager data cannot simply be in the base class, because the (static member) continuation function that
+// runs on the TXN_CLOSE hook would not be able to access it.

Review Comment:
   This comment improvement is not directly related to this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org