[jira] [Commented] (JCRVLT-301) Do not always skip installation of sub packages for older versions and log a WARN in case a subpackage is skipped

["Tobias Bocanegra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515357#comment-16515357 ] 

Tobias Bocanegra commented on JCRVLT-301:
-----------------------------------------

thanks for the PR. looks basically good. I added some comments to the PR. eg, maybe name the new enum {{FORCE_INSTALL}}.




> Do not always skip installation of sub packages for older versions and log a WARN in case a subpackage is skipped
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-301
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-301
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>    Affects Versions: 3.1.44
>            Reporter: Konrad Windszus
>            Priority: Major
>
> With JCRVLT-113 a check was implemented so that sub packages are only installed, in case a newer version of the same package (same package id) is not already installed on the system. Unfortunately in case this happens, the log is only emitted in DEBUG level (so usually not noticeable). This should at least be logged with a WARN (https://github.com/apache/jackrabbit-filevault/blame/58f86f51618c86488234580dfd11e0154fdb471a/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L480).
> Also in some cases you are definitely interested in performing a downgrade. Just think a about an aggregate package which contains not 3rd party subpackages but packages which are part of your own code base. In that case you are actually interested in the downgrade, because you deliberately installed the older aggregate package (which works fine). So this should definitely be parameterizable via the {{https://github.com/apache/jackrabbit-filevault/blob/0dcf09d58fa40cbe3bc24dcb6a00281123bd5a1c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/SubPackageHandling.java}}. I am thinking about new options {{INSTALL_ALWAYS}} and {{EXTRACT_ALWAYS}} which will always install the affected subpackages no matter which version has been installed previously.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)