[jira] Commented: (WICKET-358) Properly decode URLs

["Johan Compagner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478286 ] 

Johan Compagner commented on WICKET-358:
----------------------------------------

what about BookmarkablePageRequestTargetUrlCodingStrategy.appendParameters(AppendingStringBuffer url, Map parameters)
where we call String escapedValue = urlEncode(entry.getValue().toString()); (also done in QueryStringUrlCodingStrategy)


> Properly decode URLs
> --------------------
>
>                 Key: WICKET-358
>                 URL: https://issues.apache.org/jira/browse/WICKET-358
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Jean-Baptiste Quenot
>         Assigned To: Jean-Baptiste Quenot
>         Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled.  Sometimes the parameters are not URL-decoded.  Sometimes the empty values are not properly handled.  The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.