[GitHub] [superset] michael-s-molina commented on a change in pull request #17184: fix(Explore): Remove changes to the properties on cancel

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #17184:
URL: https://github.com/apache/superset/pull/17184#discussion_r734448499



##########
File path: superset-frontend/src/explore/components/ExploreChartHeader.jsx
##########
@@ -239,12 +239,14 @@ export class ExploreChartHeader extends React.PureComponent {
                   showTooltip
                 />
               )}
-              <PropertiesModal
-                show={this.state.isPropertiesModalOpen}
-                onHide={this.closePropertiesModal}
-                onSave={this.props.sliceUpdated}
-                slice={this.props.slice}
-              />
+              {this.state.isPropertiesModalOpen && (

Review comment:
       I wonder if using `destroyOnClose` would change anything in terms of performance or use of resources.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org