[jira] [Commented] (NIFI-1511) Incorporate Groovy unit tests as part of the build instead of via profile

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146269#comment-15146269 ] 

ASF GitHub Bot commented on NIFI-1511:
--------------------------------------

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi/pull/220

    NIFI-1511 Incorporate Groovy unit tests as part of the build instead of via profile

     Incorporating Groovy unit tests as part of the main build and providing explicit compile scope on the Groovy dependency for the scripting bundle.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/incubator-nifi NIFI-1511

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----
commit efad9b6b81f0ee95fc49905be79d0a65dd0a0c8a
Author: Aldrin Piri <al...@apache.org>
Date:   2016-02-14T00:00:05Z

    NIFI-1511 Incorporating Groovy unit tests as part of the main build and providing explicit compile scope on the Groovy dependency for the scripting bundle.

----


> Incorporate Groovy unit tests as part of the build instead of via profile
> -------------------------------------------------------------------------
>
>                 Key: NIFI-1511
>                 URL: https://issues.apache.org/jira/browse/NIFI-1511
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Tools and Build
>    Affects Versions: 0.5.0
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>
> From the mailing list:
> {quote}
> Recommend *not* running the groovy tests.  They set the groovy
> dependency to test scope which means groovy ends up not supported in
> the convenience binary.
> # Verify the build works including release audit tool (RAT) checks
>   cd nifi-0.5.0
>   mvn clean install -Pcontrib-check
> We should work to get the groovy stuff into the build without needing
> profile activation if they should be the norm.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)