You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/26 12:40:46 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #21777: Improve pipeline barrier register time
azexcy opened a new pull request, #21777:
URL: https://github.com/apache/shardingsphere/pull/21777
in order to register before `updateJobConfiguration`, make sure parent node already persist
Changes proposed in this pull request:
- Improve pipeline barrier register time
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21777: Improve pipeline barrier register time
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21777:
URL: https://github.com/apache/shardingsphere/pull/21777#issuecomment-1292389514
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21777?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21777](https://codecov.io/gh/apache/shardingsphere/pull/21777?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bade410) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e5494392bd6afa41e54a46c8ca579403d71dfffd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e549439) will **decrease** coverage by `0.00%`.
> The diff coverage is `32.51%`.
> :exclamation: Current head bade410 differs from pull request most recent head 1073ce7. Consider uploading reports for the commit 1073ce7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21777 +/- ##
============================================
- Coverage 60.79% 60.78% -0.01%
- Complexity 2444 2446 +2
============================================
Files 4117 4118 +1
Lines 57444 57482 +38
Branches 9694 9695 +1
============================================
+ Hits 34921 34941 +20
- Misses 19613 19636 +23
+ Partials 2910 2905 -5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/query/DefaultShadowAlgorithmQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9EZWZhdWx0U2hhZG93QWxnb3JpdGhtUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/AlterDefaultShadowAlgorithmStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJEZWZhdWx0U2hhZG93QWxnb3JpdGhtU3RhdGVtZW50VXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
| [.../CreateDefaultShadowAlgorithmStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlRGVmYXVsdFNoYWRvd0FsZ29yaXRobVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `51.85% <ø> (ø)` | |
| [...andler/query/BroadcastTableRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvQnJvYWRjYXN0VGFibGVSdWxlUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `62.50% <0.00%> (ø)` | |
| [...handler/query/CountShardingRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvQ291bnRTaGFyZGluZ1J1bGVRdWVyeVJlc3VsdFNldC5qYXZh) | `78.26% <ø> (ø)` | |
| [...date/CreateBroadcastTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0NyZWF0ZUJyb2FkY2FzdFRhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...update/DropBroadcastTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BCcm9hZGNhc3RUYWJsZVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `80.95% <ø> (+12.95%)` | :arrow_up: |
| [...l/parser/core/ShardingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvU2hhcmRpbmdEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tsql/parser/segment/TableReferenceRuleSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL3NlZ21lbnQvVGFibGVSZWZlcmVuY2VSdWxlU2VnbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ment/AlterShardingTableReferenceRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9BbHRlclNoYXJkaW5nVGFibGVSZWZlcmVuY2VSdWxlU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [60 more](https://codecov.io/gh/apache/shardingsphere/pull/21777/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #21777: Improve pipeline barrier register time
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #21777:
URL: https://github.com/apache/shardingsphere/pull/21777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org