You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/13 22:26:16 UTC

[GitHub] [arrow-rs] viirya edited a comment on pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

viirya edited a comment on pull request #1432:
URL: https://github.com/apache/arrow-rs/pull/1432#issuecomment-1066187145


   Note that because the struct pointers are now `Box` instead of `Arc`, it requires the users of these structs to be more careful on managing them. For example, `ArrayData::try_from`. Users need to keep these `Box`/raw pointers (in order not to release them too early) and do `release` after using the array data.
   
   That's why I personally prefer alternative `Arc` + `clone` + removing source structs' `release` approach (see https://github.com/apache/arrow-rs/pull/1436). But I'm fine with `Box` approach too if this is preferred by the community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org