You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 18:58:22 UTC
[jira] [Created] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Convert admin protocol of HRegionInterface to PB
------------------------------------------------
Key: HBASE-5621
URL: https://issues.apache.org/jira/browse/HBASE-5621
Project: HBase
Issue Type: Sub-task
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Fix For: 0.96.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253893#comment-13253893 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review6922
-----------------------------------------------------------
A few questions below... Looks great.
src/main/java/org/apache/hadoop/hbase/AdminProtocol.java
<https://reviews.apache.org/r/4714/#comment15405>
Is this right? It does more than talk to a regionserver? You have to have really nice comments on your class now that you are at the top level Jimmy (smile)
This class is only used by HBaseAdmin? Is that right? Or do other classes use it? If only HBaseAdmin, maybe it should not be top level?
src/main/java/org/apache/hadoop/hbase/ClientProtocol.java
<https://reviews.apache.org/r/4714/#comment15406>
Ditto
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
<https://reviews.apache.org/r/4714/#comment15407>
Do we have to have protobuf stuff sprinkled all over the code base? Its not too bad but just wondering. Maybe we do but just wondering. I suppose there is nothing to do about it. If we did same operation over and over w/ some pb stuff and the output was a non-pb object, then yes, we could hide the pb stuff over in a class but what we do here is particular to this method.... Can't generalize.
I do see that you have added some static methods into protobuf utils. This one is not generic so doesn't deserve to go there?
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/4714/#comment15408>
Great stuff.
src/main/java/org/apache/hadoop/hbase/client/HConnection.java
<https://reviews.apache.org/r/4714/#comment15409>
Did you say you were going to remove these from here?
src/main/java/org/apache/hadoop/hbase/client/HConnection.java
<https://reviews.apache.org/r/4714/#comment15410>
Yeah, does this belong in here?
src/main/java/org/apache/hadoop/hbase/client/HConnection.java
<https://reviews.apache.org/r/4714/#comment15411>
ditto
An AdminProtocol should have an HConnection?
Even if you moved this up into HConnectionManager for now... that'd be better.
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<https://reviews.apache.org/r/4714/#comment15412>
Yeah, I wonder if this getClient and getAdmin should be @Overrides? Shoudl they be methods of HCM altogether? Would that be better? OR should it happen elsewhere? In HBaseAdmin or in HTable where we put together protocol and connection?
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
<https://reviews.apache.org/r/4714/#comment15413>
Hurray!
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/4714/#comment15414>
Where has allt his code gone?
- Michael
On 2012-04-13 23:03:35, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-13 23:03:35)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0d22c0e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java ee4f556
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java b84a115
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a06942d
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253982#comment-13253982 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/AdminProtocol.java, line 28
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101780#file101780line28>
bq. >
bq. > Is this right? It does more than talk to a regionserver? You have to have really nice comments on your class now that you are at the top level Jimmy (smile)
bq. >
bq. > This class is only used by HBaseAdmin? Is that right? Or do other classes use it? If only HBaseAdmin, maybe it should not be top level?
bq.
bq. Jimmy Xiang wrote:
bq. Let me move it to client.
And it should not be public I'd say.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClientProtocol.java, line 29
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101781#file101781line29>
bq. >
bq. > Ditto
bq.
bq. Jimmy Xiang wrote:
bq. Will move to client.
Is this only used out of the client package? If so, yeah, move it there I'd say.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java, line 632
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101782#file101782line632>
bq. >
bq. > Do we have to have protobuf stuff sprinkled all over the code base? Its not too bad but just wondering. Maybe we do but just wondering. I suppose there is nothing to do about it. If we did same operation over and over w/ some pb stuff and the output was a non-pb object, then yes, we could hide the pb stuff over in a class but what we do here is particular to this method.... Can't generalize.
bq. >
bq. > I do see that you have added some static methods into protobuf utils. This one is not generic so doesn't deserve to go there?
bq.
bq. Jimmy Xiang wrote:
bq. For getRegionInfo, I used to put it in the protobuf util since it is used lots of places. I will move it to protobuf util.
Agree. If used more than once, move it over to protobuf util otherwise I don't see a way around not importing protobuf classes when its a particular usage.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnection.java, line 32
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101784#file101784line32>
bq. >
bq. > Did you say you were going to remove these from here?
bq.
bq. Jimmy Xiang wrote:
bq. I tried but it is hard. Let me think about it again.
Even if this stuff just moved to HCM, it'd give us a clean HConnection.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnection.java, line 260
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101784#file101784line260>
bq. >
bq. > ditto
bq. >
bq. > An AdminProtocol should have an HConnection?
bq. >
bq. > Even if you moved this up into HConnectionManager for now... that'd be better.
bq.
bq. Jimmy Xiang wrote:
bq. Let me think about it and fix it.
Thanks.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 2814
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101799#file101799line2814>
bq. >
bq. > Where has allt his code gone?
bq.
bq. Jimmy Xiang wrote:
bq. Some are moved to RegionServer as I did for 5620
But I did not see it in the patch? Its already moved?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review6922
-----------------------------------------------------------
On 2012-04-13 23:03:35, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-13 23:03:35)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0d22c0e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java ee4f556
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java b84a115
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a06942d
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254364#comment-13254364 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 2814
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101799#file101799line2814>
bq. >
bq. > Where has allt his code gone?
bq.
bq. Jimmy Xiang wrote:
bq. Some are moved to RegionServer as I did for 5620
bq.
bq. Michael Stack wrote:
bq. But I did not see it in the patch? Its already moved?
It should be in the patch, probably in the second page of touched files.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClientProtocol.java, line 29
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101781#file101781line29>
bq. >
bq. > Ditto
bq.
bq. Jimmy Xiang wrote:
bq. Will move to client.
bq.
bq. Michael Stack wrote:
bq. Is this only used out of the client package? If so, yeah, move it there I'd say.
It is used out of the client package, and the server side implements it.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/AdminProtocol.java, line 28
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101780#file101780line28>
bq. >
bq. > Is this right? It does more than talk to a regionserver? You have to have really nice comments on your class now that you are at the top level Jimmy (smile)
bq. >
bq. > This class is only used by HBaseAdmin? Is that right? Or do other classes use it? If only HBaseAdmin, maybe it should not be top level?
bq.
bq. Jimmy Xiang wrote:
bq. Let me move it to client.
bq.
bq. Michael Stack wrote:
bq. And it should not be public I'd say.
Yes, it is private.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java, line 632
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101782#file101782line632>
bq. >
bq. > Do we have to have protobuf stuff sprinkled all over the code base? Its not too bad but just wondering. Maybe we do but just wondering. I suppose there is nothing to do about it. If we did same operation over and over w/ some pb stuff and the output was a non-pb object, then yes, we could hide the pb stuff over in a class but what we do here is particular to this method.... Can't generalize.
bq. >
bq. > I do see that you have added some static methods into protobuf utils. This one is not generic so doesn't deserve to go there?
bq.
bq. Jimmy Xiang wrote:
bq. For getRegionInfo, I used to put it in the protobuf util since it is used lots of places. I will move it to protobuf util.
bq.
bq. Michael Stack wrote:
bq. Agree. If used more than once, move it over to protobuf util otherwise I don't see a way around not importing protobuf classes when its a particular usage.
Cool, will fix.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnection.java, line 32
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101784#file101784line32>
bq. >
bq. > Did you say you were going to remove these from here?
bq.
bq. Jimmy Xiang wrote:
bq. I tried but it is hard. Let me think about it again.
bq.
bq. Michael Stack wrote:
bq. Even if this stuff just moved to HCM, it'd give us a clean HConnection.
I was thinking to have a ProtocolFactory/Manager to manage the protocols, and let the connection manager to many connections only.
Let me move them to HCM for now.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review6922
-----------------------------------------------------------
On 2012-04-13 23:03:35, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-13 23:03:35)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0d22c0e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java ee4f556
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java b84a115
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a06942d
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257837#comment-13257837 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
bq. On 2012-04-19 20:43:31, Michael Stack wrote:
bq. >
I did a rebase. So it picked up some other changes if you diff 2 from 3.
bq. On 2012-04-19 20:43:31, Michael Stack wrote:
bq. > security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java, line 50
bq. > <https://reviews.apache.org/r/4714/diff/2/?file=102179#file102179line50>
bq. >
bq. > There are a bunch of import changes here. Are they all needed?
It must be from other patch. This patch doesn't touch this file.
bq. On 2012-04-19 20:43:31, Michael Stack wrote:
bq. > security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java, line 187
bq. > <https://reviews.apache.org/r/4714/diff/2/?file=102179#file102179line187>
bq. >
bq. > Why can we get away w/ removing the try/catch? Because the caller handles it?
That change in diff2 is already checked in as part of 5443 addendum. That's why it shows some change here. This patch doesn't change this file.
bq. On 2012-04-19 20:43:31, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, line 411
bq. > <https://reviews.apache.org/r/4714/diff/2-3/?file=102195#file102195line411>
bq. >
bq. > Does this belong in this patch? Is it part of another patch?
bq. From another patch due to rebasing.
bq. On 2012-04-19 20:43:31, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, line 2220
bq. > <https://reviews.apache.org/r/4714/diff/2-3/?file=102195#file102195line2220>
bq. >
bq. > Yeah, this stuff is from another patch? Why you adding it?
bq. From another patch due to rebasing.
bq. On 2012-04-19 20:43:31, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 2214
bq. > <https://reviews.apache.org/r/4714/diff/2-3/?file=102203#file102203line2214>
bq. >
bq. > Are these from Elliotts' patch?
bq. >
bq. > Maybe its reviewboard that is messing up? I'm only looking at diff between your v2 and v3 patch.
bq. From another patch due to rebasing.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review7046
-----------------------------------------------------------
On 2012-04-19 17:46:17, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 17:46:17)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java d0570b9
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 7239c5a
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java ecaf9fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 61a5988
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 759633d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 7c59995
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 7ffd6bd
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253909#comment-13253909 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/AdminProtocol.java, line 28
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101780#file101780line28>
bq. >
bq. > Is this right? It does more than talk to a regionserver? You have to have really nice comments on your class now that you are at the top level Jimmy (smile)
bq. >
bq. > This class is only used by HBaseAdmin? Is that right? Or do other classes use it? If only HBaseAdmin, maybe it should not be top level?
Let me move it to client.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClientProtocol.java, line 29
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101781#file101781line29>
bq. >
bq. > Ditto
Will move to client.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java, line 632
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101782#file101782line632>
bq. >
bq. > Do we have to have protobuf stuff sprinkled all over the code base? Its not too bad but just wondering. Maybe we do but just wondering. I suppose there is nothing to do about it. If we did same operation over and over w/ some pb stuff and the output was a non-pb object, then yes, we could hide the pb stuff over in a class but what we do here is particular to this method.... Can't generalize.
bq. >
bq. > I do see that you have added some static methods into protobuf utils. This one is not generic so doesn't deserve to go there?
For getRegionInfo, I used to put it in the protobuf util since it is used lots of places. I will move it to protobuf util.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnection.java, line 32
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101784#file101784line32>
bq. >
bq. > Did you say you were going to remove these from here?
I tried but it is hard. Let me think about it again.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnection.java, line 223
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101784#file101784line223>
bq. >
bq. > Yeah, does this belong in here?
Will fix it.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnection.java, line 260
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101784#file101784line260>
bq. >
bq. > ditto
bq. >
bq. > An AdminProtocol should have an HConnection?
bq. >
bq. > Even if you moved this up into HConnectionManager for now... that'd be better.
Let me think about it and fix it.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java, line 1376
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101785#file101785line1376>
bq. >
bq. > Yeah, I wonder if this getClient and getAdmin should be @Overrides? Shoudl they be methods of HCM altogether? Would that be better? OR should it happen elsewhere? In HBaseAdmin or in HTable where we put together protocol and connection?
Let me think about it and fix it.
bq. On 2012-04-13 23:59:40, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 2814
bq. > <https://reviews.apache.org/r/4714/diff/1/?file=101799#file101799line2814>
bq. >
bq. > Where has allt his code gone?
Some are moved to RegionServer as I did for 5620
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review6922
-----------------------------------------------------------
On 2012-04-13 23:03:35, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-13 23:03:35)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0d22c0e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java ee4f556
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java b84a115
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a06942d
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259090#comment-13259090 ]
Zhihong Yu commented on HBASE-5621:
-----------------------------------
For ServerManager.java:
{code}
- HRegionInterface hri = getServerConnection(server);
+ AdminProtocol hri = getServerConnection(server);
{code}
Can we use a better variable name to hold the AdminProtocol ? Consider how it is used below:
{code}
+ return ProtobufUtil.openRegion(hri, region, versionOfOfflineNode);
{code}
region is already HRegionInfo. hri used to denote HRegionInfo. Now it represents AdminProtocol.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Attachment: hbase_5621_v5.patch
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258994#comment-13258994 ]
stack commented on HBASE-5621:
------------------------------
We seem to have run a good few less tests, ~880 vs 906 or so.... Does it pass all tests for you Jimmy? Thanks.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Status: Open (was: Patch Available)
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
@Stack, thanks a lot for reviewing it.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5621:
-------------------------
Status: Patch Available (was: Open)
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5621:
-------------------------
Status: Open (was: Patch Available)
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258993#comment-13258993 ]
Hadoop QA commented on HBASE-5621:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523663/hbase_5621_v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 42 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1599//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1599//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1599//console
This message is automatically generated.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Attachment: hbase_5621_v4.patch
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257629#comment-13257629 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/
-----------------------------------------------------------
(Updated 2012-04-19 17:46:17.775148)
Review request for hbase.
Changes
-------
Rebased to the latest of the trunk.
Summary
-------
This is the admin part of HBase-5443. AdminProtocol part.
This addresses bug HBASE-5621.
https://issues.apache.org/jira/browse/HBASE-5621
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb
src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15
src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443
src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java d0570b9
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 7239c5a
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java ecaf9fe
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 61a5988
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 759633d
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 7c59995
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2
src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c
src/main/protobuf/Admin.proto 132c5dd
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 7ffd6bd
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10
Diff: https://reviews.apache.org/r/4714/diff
Testing
-------
All unit tests passed.
Thanks,
Jimmy
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259788#comment-13259788 ]
stack commented on HBASE-5621:
------------------------------
TestHRegion has a problem the way its written. Will fix in 5833 commit that is coming up.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259334#comment-13259334 ]
Jimmy Xiang commented on HBASE-5621:
------------------------------------
@Stack, let me check it again how many passed tests I got.
@Ted, sure. Let me fix the naming issues.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257796#comment-13257796 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review7046
-----------------------------------------------------------
security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java
<https://reviews.apache.org/r/4714/#comment15632>
There are a bunch of import changes here. Are they all needed?
security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java
<https://reviews.apache.org/r/4714/#comment15631>
Why can we get away w/ removing the try/catch? Because the caller handles it?
src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
<https://reviews.apache.org/r/4714/#comment15633>
good
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<https://reviews.apache.org/r/4714/#comment15634>
Does this belong in this patch? Is it part of another patch?
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<https://reviews.apache.org/r/4714/#comment15635>
Yeah, this stuff is from another patch? Why you adding it?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/4714/#comment15636>
Are these from Elliotts' patch?
Maybe its reviewboard that is messing up? I'm only looking at diff between your v2 and v3 patch.
- Michael
On 2012-04-19 17:46:17, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 17:46:17)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java d0570b9
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 7239c5a
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java ecaf9fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 61a5988
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 759633d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 7c59995
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 7ffd6bd
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5621:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Applied to trunk. Thanks for the patch Jimmy.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259729#comment-13259729 ]
Jimmy Xiang commented on HBASE-5621:
------------------------------------
Good to know there is already a jira to track TestProcessBasedCluster.testProcessBasedCluster failure.
Besides that one, I also have this one failed sometimes (not always): TestServerCustomProtocol. It is flaky.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257947#comment-13257947 ]
Hadoop QA commented on HBASE-5621:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523432/hbase-5621_v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 42 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestAtomicOperation
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
org.apache.hadoop.hbase.util.TestHBaseFsck
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1586//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1586//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1586//console
This message is automatically generated.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Status: Open (was: Patch Available)
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5621:
-------------------------
Attachment: hbase_5621_v4.patch
Retrying
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255036#comment-13255036 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/
-----------------------------------------------------------
(Updated 2012-04-16 20:49:59.450802)
Review request for hbase.
Changes
-------
Addressed some of Stack's comments: 1. moved Client/AdminProtcol.java to client package, 2. moved some sharable pb calls to ProtobufUtil to avoid scattering pb everywhere.
As to move some calls from HConnection to HCM, it is not as straightforward as I think. The main reason is becuase HConnection is not just a network connection to a server.
Probably it is better to handle it in a separate jira.
Summary
-------
This is the admin part of HBase-5443. AdminProtocol part.
This addresses bug HBASE-5621.
https://issues.apache.org/jira/browse/HBASE-5621
Diffs (updated)
-----
security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java 8219bea
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50
src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e
src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java d71e97e
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f
src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58
src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java d0570b9
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java ecaf9fe
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1c0541f
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 759633d
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128
src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c
src/main/protobuf/Admin.proto 132c5dd
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java b84a115
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10
Diff: https://reviews.apache.org/r/4714/diff
Testing
-------
All unit tests passed.
Thanks,
Jimmy
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Status: Patch Available (was: Open)
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259709#comment-13259709 ]
Zhihong Yu commented on HBASE-5621:
-----------------------------------
Can you list the tests that failed on your machine ?
For security profile, TestProcessBasedCluster.testProcessBasedCluster fails consistently and is tracked by HBASE-5851.
Other than that test, we should be careful.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259699#comment-13259699 ]
Jimmy Xiang commented on HBASE-5621:
------------------------------------
I addressed the naming issue Ted pointed out.
I think I got all regular tests passed: 537 small + 648 medium + 297 large = 1482
With security, there are couple tests failed. I am looking into them. I don't think it's caused by this patch. Should we handle them in a different jira?
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259742#comment-13259742 ]
Hadoop QA commented on HBASE-5621:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523812/hbase_5621_v5.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 42 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1609//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1609//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1609//console
This message is automatically generated.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253846#comment-13253846 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
This is the admin part of HBase-5443. AdminProtocol part.
This addresses bug HBASE-5621.
https://issues.apache.org/jira/browse/HBASE-5621
Diffs
-----
src/main/java/org/apache/hadoop/hbase/AdminProtocol.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/ClientProtocol.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f
src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58
src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0d22c0e
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128
src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java ee4f556
src/main/protobuf/Admin.proto 132c5dd
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java b84a115
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a06942d
Diff: https://reviews.apache.org/r/4714/diff
Testing
-------
All unit tests passed.
Thanks,
Jimmy
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259748#comment-13259748 ]
Jimmy Xiang commented on HBASE-5621:
------------------------------------
TestAssignmentManager passed locally.
For secure profile, TestHRegion also has some issue.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Status: Patch Available (was: Open)
Minor changes to fix TestHBaseFsck failure and some security test failures.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257914#comment-13257914 ]
stack commented on HBASE-5621:
------------------------------
Want to put your patch up here Jimmy and run it by hadoopqa? Thanks.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258379#comment-13258379 ]
Jimmy Xiang commented on HBASE-5621:
------------------------------------
Looking into the failed unit tests.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258963#comment-13258963 ]
Hadoop QA commented on HBASE-5621:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523657/hbase_5621_v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 42 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1598//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1598//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1598//console
This message is automatically generated.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5621:
-------------------------------
Attachment: hbase-5621_v3.patch
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of
HRegionInterface to PB
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257912#comment-13257912 ]
jiraposter@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review7051
-----------------------------------------------------------
Ship it!
I'm good w/ this patch. Good stuff Jimmy
src/main/java/org/apache/hadoop/hbase/client/HConnection.java
<https://reviews.apache.org/r/4714/#comment15645>
Please file an issue to address this recursion (an AdminProtocol 'has' a HConnection but you get the AdminProtocol from an HConnection).
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
<https://reviews.apache.org/r/4714/#comment15646>
This is a noop
- Michael
On 2012-04-19 17:46:17, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4714/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 17:46:17)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the admin part of HBase-5443. AdminProtocol part.
bq.
bq.
bq. This addresses bug HBASE-5621.
bq. https://issues.apache.org/jira/browse/HBASE-5621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79
bq. src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50
bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb
bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443
bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java d0570b9
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 7239c5a
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830
bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java ecaf9fe
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 61a5988
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 759633d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 7c59995
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c
bq. src/main/protobuf/Admin.proto 132c5dd
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b
bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b
bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de
bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27
bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 7ffd6bd
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10
bq.
bq. Diff: https://reviews.apache.org/r/4714/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira