You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/27 10:52:18 UTC

[GitHub] [spark] 07ARB opened a new pull request #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

07ARB opened a new pull request #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024
 
 
   ### What changes were proposed in this pull request?
   lpad and rpad built in function should throw Error or Exception for invalid length value Instead of empty string.
   
   ### Why are the changes needed?
   We should throw Error or Exception message, if user trying to perform LPAD/RPAD operation using invalid argument.
   
   ```
   SELECT lpad('hi', 'ankit', '?') => ""   <previous behaviours>
   SELECT lpad('hi', 'ankit', '?') => "Error in query: Invalid argument, TypeCheckFailure(argument 2 requires int type, however, ''ankit'' is of string type.);"   <After this PR>
   
   SELECT rpad('hi', 'raj', '?') => ""   <previous behaviours>
   SELECT lpad('hi', 'raj', '?') => "Error in query: Invalid argument, TypeCheckFailure(argument 2 requires int type, however, ''ankit'' is of string type.);"   <After this PR>
   ```
   
   
   ### Does this PR introduce any user-facing change?
   YES
   ![Screenshot 2019-12-27 at 4 09 46 PM](https://user-images.githubusercontent.com/8948111/71514275-e8577180-28c3-11ea-9d0b-9b4f3027ddeb.png)
   
   ![Screenshot 2019-12-27 at 4 15 55 PM](https://user-images.githubusercontent.com/8948111/71514356-37050b80-28c4-11ea-87ab-0406db6d720e.png)
   ![Screenshot 2019-12-27 at 4 16 52 PM](https://user-images.githubusercontent.com/8948111/71514395-674caa00-28c4-11ea-91dc-37c253f451b0.png)
   
   ![Screenshot 2019-12-27 at 4 17 05 PM](https://user-images.githubusercontent.com/8948111/71514392-5dc34200-28c4-11ea-94bd-70d439c5216f.png)
   
   
   ### How was this patch tested?
   Old unit tests correct as per this jira.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395026
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569397076
 
 
   in Hive : SELECT lpad('hihhhhhhhhhhhhhhhhhhhhhhh', 'Expected int', '????????????');
    Error: Error while compiling statement: FAILED: SemanticException [Error 10016]: Line 1:67 Argument type mismatch ''????????????'': lpad only takes INT/SHORT/BYTE types as 2-ths argument, got DECIMAL (state=42000,code=10016)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569396869
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569397537
 
 
   @maropu , you mean i should use TypeCoercion.scala functionality to resolve this issue ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569246323
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569246559
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569396873
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115885/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569399531
 
 
   I just meant not the lpad behaivour but the type coercion behaivour;
   ```
   hive> SELECT '1' + 1;
   2.0
   ```
   If you want to fix this, I think we need to update the implicit cast logics instead of the lpad logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395593
 
 
   yes , we need to discuss whether we need to handle or not.
   but what i feel, we should show error message, so that end user will get some meaningful information.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569397537
 
 
   @maropu , you mean i should use TypeCoercion.scala functionality to resolve this issue ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395977
 
 
   Yea, I think this behaivour is weird, but we just follow the hive behviour;
   https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L948-L950
   
   We are planning to support ansi-compatible type coercion, so I think this issue will be resolved if that supported. cc: @gengliangwang @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569396856
 
 
   **[Test build #115885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115885/testReport)** for PR 27024 at commit [`2793ac6`](https://github.com/apache/spark/commit/2793ac6cf38f32ce8a7b12a6edcc23a65ff3cff3).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395415
 
 
   **[Test build #115885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115885/testReport)** for PR 27024 at commit [`2793ac6`](https://github.com/apache/spark/commit/2793ac6cf38f32ce8a7b12a6edcc23a65ff3cff3).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569245404
 
 
   @cloud-fan and @srowen , please review this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395503
 
 
   But, there are many functions having the same behaivour? e.g.,
   ```
   scala> sql("SELECT substring_index('www.apache.org', '.', 'Must be integer')").show()
   +----------------------------------------------------------------+
   |substring_index(www.apache.org, ., CAST(Must be integer AS INT))|
   +----------------------------------------------------------------+
   |                                                            null|
   +----------------------------------------------------------------+
   ```
   Actually, implicit casts do so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395028
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20675/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569399704
 
 
   oh , ok got it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395593
 
 
   yes , we need to discuss whether we need to handle or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569245404
 
 
   @cloud-fan, please help me to review this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569396869
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395064
 
 
   @maropu , Thank you

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569246323
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] 07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569245404
 
 
   @cloud-fan and @srowen , please help me to review this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395026
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569394962
 
 
   ok to test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569396873
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115885/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395028
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20675/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569246559
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395415
 
 
   **[Test build #115885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115885/testReport)** for PR 27024 at commit [`2793ac6`](https://github.com/apache/spark/commit/2793ac6cf38f32ce8a7b12a6edcc23a65ff3cff3).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org