[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5094: 5082 fix patch tx rule

["keon94 (via GitHub)" <gi...@apache.org>]

keon94 commented on code in PR #5094:
URL: https://github.com/apache/incubator-devlake/pull/5094#discussion_r1185391355


##########
backend/test/helper/api.go:
##########
@@ -134,43 +136,43 @@ func (d *DevlakeClient) ListProjects() apiProject.PaginatedProjects {
 	}, http.MethodGet, fmt.Sprintf("%s/projects", d.Endpoint), nil, nil)
 }
 
-func (d *DevlakeClient) CreateScope(pluginName string, connectionId uint64, scopes ...any) any {
+func (d *DevlakeClient) CreateScope(pluginName string, connectionId uint64, scopes ...any) []Map {

Review Comment:
   Semantically, these generic client APIs are meant to be used in conjunction with the helper.Cast[Type] method, e.g.
   ```helper.Cast[[]AzureDevopsGitRepo](client.CreateScope(azurePlugin, connection.ID, scopes))```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org