You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/08/01 20:13:54 UTC
[GitHub] [shiro] bmarwell opened a new pull request #315: Meecrowave it
bmarwell opened a new pull request #315:
URL: https://github.com/apache/shiro/pull/315
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SHIRO-802) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[SHIRO-XXX] - Fixes bug in SessionManager`,
where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [X] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #315: Container ITs: OpenLiberty and Meecrowave
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #315:
URL: https://github.com/apache/shiro/pull/315#issuecomment-892465492
Some JDK modules seems to be missing starting Java 16 on CI:
```
Error: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.529 s <<< FAILURE! - in org.apache.shiro.testing.jaxrs.openliberty.OpenLibertyIT
Error: testGetUsersBasicAuthenticated Time elapsed: 0.136 s <<< ERROR!
java.lang.reflect.InaccessibleObjectException: Unable to make field private static volatile java.net.Authenticator java.net.Authenticator.theAuthenticator accessible: module java.base does not "opens java.net" to unnamed module @2a79781f
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #315: Container ITs: OpenLiberty and Meecrowave
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #315:
URL: https://github.com/apache/shiro/pull/315#issuecomment-892537120
> > Some JDK modules seems to be missing starting Java 16 on CI:
>
> Probably blocked by this one: [OpenLiberty/open-liberty#14096](https://github.com/OpenLiberty/open-liberty/issues/14096)
Ok, let's wait for the bugfix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a change in pull request #315: Container ITs: OpenLiberty and Meecrowave
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #315:
URL: https://github.com/apache/shiro/pull/315#discussion_r733539844
##########
File path: integration-tests/jaxrs/openliberty/pom.xml
##########
@@ -0,0 +1,149 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.shiro.integrationtests.jaxrs</groupId>
+ <artifactId>shiro-its-jaxrs</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>shiro-its-jaxrs-openliberty</artifactId>
+ <name>Apache Shiro :: ITs :: JAX-RS :: OpenLiberty</name>
+
+ <properties>
+ <liberty.var.default.http.port>9080</liberty.var.default.http.port>
+ <liberty.var.default.https.port>9443</liberty.var.default.https.port>
+ <liberty.var.app.filename>shiro-its-jaxrs-app-${project.version}</liberty.var.app.filename>
+ <liberty.var.app.context.root>/</liberty.var.app.context.root>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.shiro.integrationtests.jaxrs</groupId>
+ <artifactId>shiro-its-jaxrs-app</artifactId>
+ <type>war</type>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.shiro.integrationtests.jaxrs</groupId>
+ <artifactId>shiro-its-jaxrs-tests</artifactId>
+ <type>jar</type>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.openliberty.tools</groupId>
+ <artifactId>liberty-maven-plugin</artifactId>
+ <version>3.3.4</version>
+ <configuration>
+ <serverName>shiro-its-jaxrs-openliberty</serverName>
+ <features>
+ <acceptLicense>true</acceptLicense>
+ <feature>jaxrs-2.1</feature>
+ <feature>servlet-4.0</feature>
+ <feature>cdi-2.0</feature>
+ <feature>jsonb-1.0</feature>
+ </features>
+ <deployPackages>dependencies</deployPackages>
+ <copyDependencies>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>jcl-over-slf4j</artifactId>
+ <version>1.7.30</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ <version>2.14.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <version>2.14.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j-impl</artifactId>
+ <version>2.14.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>1.7.30</version>
+ </dependency>
+ </copyDependencies>
+ </configuration>
+ <executions>
+ <execution>
+ <id>test-start</id>
+ <phase>pre-integration-test</phase>
+ <goals>
+ <goal>create</goal>
+ <goal>deploy</goal>
+ <goal>install-feature</goal>
+ <goal>start</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>test-stop</id>
+ <phase>post-integration-test</phase>
+ <goals>
+ <goal>stop</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <configuration>
+ <systemPropertyVariables>
+ <http.port>${liberty.var.default.http.port}</http.port>
+ <war.name>${liberty.var.app.context.root}</war.name>
+ <app.context.root>${liberty.var.app.context.root}</app.context.root>
+ </systemPropertyVariables>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>jdk17</id>
+ <activation>
+ <jdk>[16,)</jdk>
+ </activation>
+ <properties>
+ <surefire.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</surefire.argLine>
+ <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
Review comment:
Had to add this b/c of surefire (not b/c of Liberty, actually).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #315: Container ITs: OpenLiberty and Meecrowave
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #315:
URL: https://github.com/apache/shiro/pull/315#issuecomment-892537120
> > Some JDK modules seems to be missing starting Java 16 on CI:
>
> Probably blocked by this one: [OpenLiberty/open-liberty#14096](https://github.com/OpenLiberty/open-liberty/issues/14096)
Ok, let's wait for the bugfix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on pull request #315: Container ITs: OpenLiberty and Meecrowave
Posted by GitBox <gi...@apache.org>.
bmarwell commented on pull request #315:
URL: https://github.com/apache/shiro/pull/315#issuecomment-892466583
> Some JDK modules seems to be missing starting Java 16 on CI:
Probably blocked by this one: https://github.com/OpenLiberty/open-liberty/issues/14096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell merged pull request #315: Container ITs: OpenLiberty and Meecrowave
Posted by GitBox <gi...@apache.org>.
bmarwell merged pull request #315:
URL: https://github.com/apache/shiro/pull/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org