You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/01/03 16:31:00 UTC

[GitHub] carbondata pull request #1744: [CARBONDATA-1955] Delta DataType calculation ...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1744#discussion_r159467557
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java ---
    @@ -216,8 +216,13 @@ private static DataType fitDelta(DataType dataType, Object max, Object min) {
         } else if (dataType == DataTypes.INT) {
           value = (long) (int) max - (long) (int) min;
    --- End diff --
    
    Even for all other datatypes has same problem right, I mean there is a chance of giving bigger datatype than original type.


---