[jira] [Commented] (HTTPCLIENT-1920) Cached HEAD requests without response body

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464154#comment-16464154 ] 

ASF GitHub Bot commented on HTTPCLIENT-1920:
--------------------------------------------

Github user comcast-jonm commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/101
  
    Yes, this approach is not the right one, as @fxbonnet mentioned. 👎 
    
    I'll comment on https://issues.apache.org/jira/browse/HTTPCLIENT-1920.



> Cached HEAD requests without response body
> ------------------------------------------
>
>                 Key: HTTPCLIENT-1920
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1920
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (classic)
>    Affects Versions: 4.4.1, 4.5
>            Reporter: Tobias Gesellchen
>            Priority: Major
>              Labels: pull-request-available
>
> Since httpclient-cache 4.4 {{HEAD}} requests can be cached with a {{null}} response body. Subsequent {{GET}} requests to the same target then use the headers "If-None-Match" and "If-Modified-Since" to leverage caching via HTTP protocol. In that case a server can respond with status code 304 and an empty response body, which leads to an invalid cache entry.
> The GitHub PR #101 proposes a fix, which I have tested locally. The PR is based on httpclient-cache 4.5, but should easily be backported to 4.4. I haven't looked into the upcoming 5.x sources, yet.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org