You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dmitry Konstantinov (Jira)" <ji...@apache.org> on 2025/01/01 13:23:00 UTC

[jira] [Updated] (CASSANDRA-20176) Reduce memory allocation in SEP Worker spin wait logic

     [ https://issues.apache.org/jira/browse/CASSANDRA-20176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Konstantinov updated CASSANDRA-20176:
--------------------------------------------
    Change Category: Performance
         Complexity: Normal
             Status: Open  (was: Triage Needed)

> Reduce memory allocation in SEP Worker spin wait logic
> ------------------------------------------------------
>
>                 Key: CASSANDRA-20176
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20176
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Local/Other
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>         Attachments: image-2025-01-01-13-14-02-562.png, image-2025-01-01-13-15-16-767.png
>
>
> There is a quite massive memory allocation within spin waiting logic in SEP Executor: org.apache.cassandra.concurrent.SEPWorker#doWaitSpin for some workloads. For example it is observed for a writing test described in CASSANDRA-20165 where ~8.5% of total allocations are from this logic:
> !image-2025-01-01-13-14-02-562.png|width=570!
> !image-2025-01-01-13-15-16-767.png|width=570!
> The logic selects a random time period to park a thread by LockSupport.parkNanos and put the thread into a ConcurrentSkipListMap using wake up time as a key, so the map is used as a concurrent priority queue. Once the parking is finished - the thread removes itself from the map. When a thread is needed to schedule a task - we take a spinning thread with the smallest wake up time from the map.
> We can try to implement another algorithm for this logic without memory allocation overheads, for example based on a Timing Wheel data structure.
> Note: it also makes sense to check granularity of actual parking time (https://hazelcast.com/blog/locksupport-parknanos-under-the-hood-and-the-curious-case-of-parking/)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org