You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2026/07/31 14:51:57 UTC

[PR] Show user display names for triggered runs and HITL responses [airflow]

pierrejeambrun opened a new pull request, #70836:
URL: https://github.com/apache/airflow/pull/70836

   Follow-up to #70583, which added `BaseUser.get_display_name` and used it so audit-log rows show a friendly user name instead of the raw login.
   
   Several other user-facing fields still recorded `get_name()` (the raw login):
   
   - `triggering_user_name` on manually triggered Dag runs, backfills, and asset materializations β€” shown in the Dag Runs table and the Run header.
   - The HITL responder name (`responded_by`) β€” shown in the HITL table and response form.
   
   These now use `get_display_name()` too, so what the user sees is consistent with the audit log. For auth managers that don't override `get_display_name` (Simple, Keycloak) it falls back to `get_name`, so their behavior is unchanged; FAB users get their full name.
   
   The edge3 worker maintenance-comment site (`get_name()` embedded in a comment string) is intentionally left out and will be a separate follow-up: that provider can run against an older core without the `get_display_name` interface, so it needs a `hasattr(user, "get_display_name")` compatibility guard.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes β€” Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show user display names for triggered runs and HITL responses [airflow]

Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #70836:
URL: https://github.com/apache/airflow/pull/70836#issuecomment-5163247460

   Looks simple enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show user display names for triggered runs and HITL responses [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #70836:
URL: https://github.com/apache/airflow/pull/70836#issuecomment-5163329987

   Do we want to backport this? I feel it’s not necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show user display names for triggered runs and HITL responses [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #70836:
URL: https://github.com/apache/airflow/pull/70836#issuecomment-5144289949

   ## Before
   <img width="575" height="321" alt="Screenshot 2026-07-31 at 16 55 18" src="https://github.com/user-attachments/assets/5a0ade58-ffa9-4de0-9ec3-023d11f19d44" />
   <img width="927" height="708" alt="Screenshot 2026-07-31 at 16 56 50" src="https://github.com/user-attachments/assets/45f7d51a-6cf7-4b76-9950-ddaf01f7ac8c" />
   <img width="1571" height="509" alt="Screenshot 2026-07-31 at 16 57 46" src="https://github.com/user-attachments/assets/46b16df1-2f58-432f-bdff-6fc5141c3987" />
   
   
   ## After
   <img width="778" height="494" alt="Screenshot 2026-07-31 at 16 58 40" src="https://github.com/user-attachments/assets/8b6fdfff-3437-46d5-881b-aeabb87b1246" />
   <img width="936" height="424" alt="Screenshot 2026-07-31 at 16 59 54" src="https://github.com/user-attachments/assets/0ade027e-df59-49b7-a22e-d5dcad79a3f3" />
   
   
   <img width="1164" height="443" alt="Screenshot 2026-07-31 at 16 59 06" src="https://github.com/user-attachments/assets/35a8f721-07a3-4531-bb80-9a4c7f7d3d36" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show user display names for triggered runs and HITL responses [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #70836:
URL: https://github.com/apache/airflow/pull/70836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org