[GitHub] hrsakai commented on a change in pull request #785: Admin-api to reset cursor by position

[gi...@git.apache.org]

hrsakai commented on a change in pull request #785: Admin-api to reset cursor by position
URL: https://github.com/apache/incubator-pulsar/pull/785#discussion_r141540438
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/PersistentTopics.java
 ##########
 @@ -906,11 +905,10 @@ public void expireMessagesForAllSubscriptions(@PathParam("property") String prop
 
     @POST
     @Path("/{property}/{cluster}/{namespace}/{destination}/subscription/{subName}/resetcursor/{timestamp}")
-    @ApiOperation(value = "Reset subscription to message position closest to absolute timestamp (in ms).", notes = "There should not be any active consumers on the subscription.")
+    @ApiOperation(value = "Reset subscription to message position closest to absolute timestamp (in ms).", notes = "First fence the cursor and disconnects all active consumers before resetting cursor.")
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
-            @ApiResponse(code = 404, message = "Topic does not exist"),
-            @ApiResponse(code = 405, message = "Not supported for global and non-persistent topics"),
-            @ApiResponse(code = 412, message = "Subscription has active consumers") })
+            @ApiResponse(code = 404, message = "Topic/Subscription does not exist"),
+            @ApiResponse(code = 405, message = "Not supported for global topics")})
 
 Review comment:
   Already support global topics?
   https://github.com/apache/incubator-pulsar/pull/79
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services