You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by al...@apache.org on 2015/01/07 20:53:54 UTC
[1/3] cassandra git commit: Add an extra version check to
MigrationTask
Repository: cassandra
Updated Branches:
refs/heads/trunk 34f9c97a5 -> 6041d41cd
Add an extra version check to MigrationTask
patch by Aleksey Yeschenko; reviewed by Tyler Hobbs for CASSANDRA-8462
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8078a58f
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8078a58f
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8078a58f
Branch: refs/heads/trunk
Commit: 8078a58f2ee625e497bd938ed35514bb003d03dc
Parents: 3679b1b
Author: Aleksey Yeschenko <al...@apache.org>
Authored: Wed Jan 7 22:39:00 2015 +0300
Committer: Aleksey Yeschenko <al...@apache.org>
Committed: Wed Jan 7 22:39:00 2015 +0300
----------------------------------------------------------------------
CHANGES.txt | 1 +
.../org/apache/cassandra/service/MigrationManager.java | 2 +-
.../org/apache/cassandra/service/MigrationTask.java | 13 ++++++++++---
3 files changed, 12 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8078a58f/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 7aad4c0..c1bb28c 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.0.12:
+ * Add an extra version check to MigrationTask (CASSANDRA-8462)
* Ensure SSTableWriter cleans up properly after failure (CASSANDRA-8499)
* Increase bf true positive count on key cache hit (CASSANDRA-8525)
* Move MeteredFlusher to its own thread (CASSANDRA-8485)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8078a58f/src/java/org/apache/cassandra/service/MigrationManager.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/MigrationManager.java b/src/java/org/apache/cassandra/service/MigrationManager.java
index b474bdc..f66b738 100644
--- a/src/java/org/apache/cassandra/service/MigrationManager.java
+++ b/src/java/org/apache/cassandra/service/MigrationManager.java
@@ -141,7 +141,7 @@ public class MigrationManager
return StageManager.getStage(Stage.MIGRATION).submit(new MigrationTask(endpoint));
}
- private static boolean shouldPullSchemaFrom(InetAddress endpoint)
+ public static boolean shouldPullSchemaFrom(InetAddress endpoint)
{
/*
* Don't request schema from nodes with a differnt or unknonw major version (may have incompatible schema)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8078a58f/src/java/org/apache/cassandra/service/MigrationTask.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/MigrationTask.java b/src/java/org/apache/cassandra/service/MigrationTask.java
index 93572f0..0944c55 100644
--- a/src/java/org/apache/cassandra/service/MigrationTask.java
+++ b/src/java/org/apache/cassandra/service/MigrationTask.java
@@ -48,7 +48,14 @@ class MigrationTask extends WrappedRunnable
public void runMayThrow() throws Exception
{
- MessageOut message = new MessageOut<>(MessagingService.Verb.MIGRATION_REQUEST, null, MigrationManager.MigrationsSerializer.instance);
+ // There is a chance that quite some time could have passed between now and the MM#maybeScheduleSchemaPull(),
+ // potentially enough for the endpoint node to restart - which is an issue if it does restart upgraded, with
+ // a higher major.
+ if (!MigrationManager.shouldPullSchemaFrom(endpoint))
+ {
+ logger.info("Skipped sending a migration request: node {} has a higher major version now.", endpoint);
+ return;
+ }
if (!FailureDetector.instance.isAlive(endpoint))
{
@@ -56,9 +63,10 @@ class MigrationTask extends WrappedRunnable
return;
}
+ MessageOut message = new MessageOut<>(MessagingService.Verb.MIGRATION_REQUEST, null, MigrationManager.MigrationsSerializer.instance);
+
IAsyncCallback<Collection<RowMutation>> cb = new IAsyncCallback<Collection<RowMutation>>()
{
- @Override
public void response(MessageIn<Collection<RowMutation>> message)
{
try
@@ -75,7 +83,6 @@ class MigrationTask extends WrappedRunnable
}
}
- @Override
public boolean isLatencyForSnitch()
{
return false;
[2/3] cassandra git commit: Merge branch 'cassandra-2.0' into
cassandra-2.1
Posted by al...@apache.org.
Merge branch 'cassandra-2.0' into cassandra-2.1
Conflicts:
src/java/org/apache/cassandra/service/MigrationTask.java
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/561293d1
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/561293d1
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/561293d1
Branch: refs/heads/trunk
Commit: 561293d132e3fa73d1e0f43d3bd0c54137f88a15
Parents: 68be72f 8078a58
Author: Aleksey Yeschenko <al...@apache.org>
Authored: Wed Jan 7 22:51:42 2015 +0300
Committer: Aleksey Yeschenko <al...@apache.org>
Committed: Wed Jan 7 22:51:42 2015 +0300
----------------------------------------------------------------------
CHANGES.txt | 3 +--
.../org/apache/cassandra/service/MigrationManager.java | 2 +-
.../org/apache/cassandra/service/MigrationTask.java | 12 ++++++++++--
3 files changed, 12 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/561293d1/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 58d94ed,c1bb28c..dfed732
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,57 -1,5 +1,56 @@@
-2.0.12:
+2.1.3
+ * Fix case-sensitivity of index name on CREATE and DROP INDEX
+ statements (CASSANDRA-8365)
+ * Better detection/logging for corruption in compressed sstables (CASSANDRA-8192)
+ * Use the correct repairedAt value when closing writer (CASSANDRA-8570)
+ * (cqlsh) Handle a schema mismatch being detected on startup (CASSANDRA-8512)
+ * Properly calculate expected write size during compaction (CASSANDRA-8532)
+ * Invalidate affected prepared statements when a table's columns
+ are altered (CASSANDRA-7910)
+ * Stress - user defined writes should populate sequentally (CASSANDRA-8524)
+ * Fix regression in SSTableRewriter causing some rows to become unreadable
+ during compaction (CASSANDRA-8429)
+ * Run major compactions for repaired/unrepaired in parallel (CASSANDRA-8510)
+ * (cqlsh) Fix compression options in DESCRIBE TABLE output when compression
+ is disabled (CASSANDRA-8288)
+ * (cqlsh) Fix DESCRIBE output after keyspaces are altered (CASSANDRA-7623)
+ * Make sure we set lastCompactedKey correctly (CASSANDRA-8463)
+ * (cqlsh) Fix output of CONSISTENCY command (CASSANDRA-8507)
+ * (cqlsh) Fixed the handling of LIST statements (CASSANDRA-8370)
+ * Make sstablescrub check leveled manifest again (CASSANDRA-8432)
+ * Check first/last keys in sstable when giving out positions (CASSANDRA-8458)
+ * Disable mmap on Windows (CASSANDRA-6993)
+ * Add missing ConsistencyLevels to cassandra-stress (CASSANDRA-8253)
+ * Add auth support to cassandra-stress (CASSANDRA-7985)
+ * Fix ArrayIndexOutOfBoundsException when generating error message
+ for some CQL syntax errors (CASSANDRA-8455)
+ * Scale memtable slab allocation logarithmically (CASSANDRA-7882)
+ * cassandra-stress simultaneous inserts over same seed (CASSANDRA-7964)
+ * Reduce cassandra-stress sampling memory requirements (CASSANDRA-7926)
+ * Ensure memtable flush cannot expire commit log entries from its future (CASSANDRA-8383)
+ * Make read "defrag" async to reclaim memtables (CASSANDRA-8459)
+ * Remove tmplink files for offline compactions (CASSANDRA-8321)
+ * Reduce maxHintsInProgress (CASSANDRA-8415)
+ * BTree updates may call provided update function twice (CASSANDRA-8018)
+ * Release sstable references after anticompaction (CASSANDRA-8386)
+ * Handle abort() in SSTableRewriter properly (CASSANDRA-8320)
+ * Fix high size calculations for prepared statements (CASSANDRA-8231)
+ * Centralize shared executors (CASSANDRA-8055)
+ * Fix filtering for CONTAINS (KEY) relations on frozen collection
+ clustering columns when the query is restricted to a single
+ partition (CASSANDRA-8203)
+ * Do more aggressive entire-sstable TTL expiry checks (CASSANDRA-8243)
+ * Add more log info if readMeter is null (CASSANDRA-8238)
+ * add check of the system wall clock time at startup (CASSANDRA-8305)
+ * Support for frozen collections (CASSANDRA-7859)
+ * Fix overflow on histogram computation (CASSANDRA-8028)
+ * Have paxos reuse the timestamp generation of normal queries (CASSANDRA-7801)
+ * Fix incremental repair not remove parent session on remote (CASSANDRA-8291)
+ * Improve JBOD disk utilization (CASSANDRA-7386)
+ * Log failed host when preparing incremental repair (CASSANDRA-8228)
+ * Force config client mode in CQLSSTableWriter (CASSANDRA-8281)
+Merged from 2.0:
- =======
- 2.0.12:
+ * Add an extra version check to MigrationTask (CASSANDRA-8462)
* Ensure SSTableWriter cleans up properly after failure (CASSANDRA-8499)
* Increase bf true positive count on key cache hit (CASSANDRA-8525)
* Move MeteredFlusher to its own thread (CASSANDRA-8485)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/561293d1/src/java/org/apache/cassandra/service/MigrationManager.java
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/561293d1/src/java/org/apache/cassandra/service/MigrationTask.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/service/MigrationTask.java
index 9fdbff4,0944c55..2d2a1f1
--- a/src/java/org/apache/cassandra/service/MigrationTask.java
+++ b/src/java/org/apache/cassandra/service/MigrationTask.java
@@@ -56,10 -63,11 +63,12 @@@ class MigrationTask extends WrappedRunn
return;
}
+ MessageOut message = new MessageOut<>(MessagingService.Verb.MIGRATION_REQUEST, null, MigrationManager.MigrationsSerializer.instance);
+
- IAsyncCallback<Collection<RowMutation>> cb = new IAsyncCallback<Collection<RowMutation>>()
+ IAsyncCallback<Collection<Mutation>> cb = new IAsyncCallback<Collection<Mutation>>()
{
- public void response(MessageIn<Collection<RowMutation>> message)
+ @Override
+ public void response(MessageIn<Collection<Mutation>> message)
{
try
{
[3/3] cassandra git commit: Merge branch 'cassandra-2.1' into trunk
Posted by al...@apache.org.
Merge branch 'cassandra-2.1' into trunk
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6041d41c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6041d41c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6041d41c
Branch: refs/heads/trunk
Commit: 6041d41cd867a93d795a7c86f411b2159949073d
Parents: 34f9c97 561293d
Author: Aleksey Yeschenko <al...@apache.org>
Authored: Wed Jan 7 22:52:13 2015 +0300
Committer: Aleksey Yeschenko <al...@apache.org>
Committed: Wed Jan 7 22:52:13 2015 +0300
----------------------------------------------------------------------
CHANGES.txt | 3 +--
.../org/apache/cassandra/service/MigrationManager.java | 2 +-
.../org/apache/cassandra/service/MigrationTask.java | 12 ++++++++++--
3 files changed, 12 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/6041d41c/CHANGES.txt
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/6041d41c/src/java/org/apache/cassandra/service/MigrationManager.java
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/6041d41c/src/java/org/apache/cassandra/service/MigrationTask.java
----------------------------------------------------------------------