You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/03 14:59:00 UTC

[jira] [Commented] (CB-13535) Add app events for connecting and disconnecting calls

    [ https://issues.apache.org/jira/browse/CB-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237695#comment-16237695 ] 

ASF GitHub Bot commented on CB-13535:
-------------------------------------

SpencerEJameson opened a new pull request #348: CB-13535: (ios) Add CallStart/CallEnd events to fire with Resign/Active events
URL: https://github.com/apache/cordova-ios/pull/348
 
 
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Adds new events to trigger alongside the current resign/active events to specifically denote when a call started and ended. The new events are **callstart** and **callend**
   
   ### What testing has been done on this change?
   Tested against iOS 10.x+ and verified that upon calls connecting and disconnecting the events were triggering correctly. I did not have an iOS device less than 10.x to test with.
   
   ### Usage in App
   `document.addEventListener("callstart", function() {
           console.log("Call Start");
         });`
   
   `document.addEventListener("callend", function() {
           console.log("Call End);
         });`
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add app events for connecting and disconnecting calls
> -----------------------------------------------------
>
>                 Key: CB-13535
>                 URL: https://issues.apache.org/jira/browse/CB-13535
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-ios
>            Reporter: Spencer Jameson
>            Assignee: Suraj Pindoria
>            Priority: Normal
>
> The app resign/active events that Cordova fires trigger for multiple phone events. Example: connecting a call and locking the screen app both trigger the *resign* event, while disconnecting a call and unlocking the screen trigger the *active* event. It would be convenient to have distinct events that fire for calls connecting and ending to tie into, aside from the generic *active* and *resign* events.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org