You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/05/09 16:33:23 UTC

[Bug 54944] New: Enhancements to TestFormAuthenticator

https://issues.apache.org/bugzilla/show_bug.cgi?id=54944

            Bug ID: 54944
           Summary: Enhancements to TestFormAuthenticator
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: Brian@PingToo.com
    Classification: Unclassified

Created attachment 30266
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30266&action=edit
svn diff: update to test class

I have attached an extensive patch to this existing test class. The main
benefit is better comments and self-documenting arguments to the common worker
methods, which should be helpful to anyone investigating tomcat authentication
behaviour but who does not have a detailed understanding of its internal logic.

The motive and techniques used here bring the source into line with an earlier
enhancement to the TestNonLoginAndBasicAuthenticator, i.e.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190#c4

All tests should pass with the latest trunk. Code style should be acceptable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 54944] Enhancements to TestFormAuthenticator

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54944

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Thanks for the patch. Applied (with one minor change) to trunk and 7.0.x and
will be included in 7.0.41 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org