You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/21 23:34:12 UTC

[GitHub] [airflow] syudb opened a new pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

syudb opened a new pull request #10461:
URL: https://github.com/apache/airflow/pull/10461


   This PR addresses an issue with the way GET requests were being built/sent.  In the original implementation, the request payload is sent in the body of the request and not in the query string parameters, which can be lost when the traffic passes through a WAF.  
   
   This in turn causes the operator to fail while polling for job status (GET) after a successful submission (POST).
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] syudb commented on pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

syudb commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-679588649


   So just to clear up any confusion - the provider hooks exist in a different path in v1-10-stable, so even if I make a change to a provider hook in master, a committer will port those changes to the old structure?  Asking to see if since my PR to master was accepted, then if this one should just be closed.  Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-678556493

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] stale[bot] closed pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

stale[bot] closed pull request #10461:
URL: https://github.com/apache/airflow/pull/10461


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-751251902


   @syudb You can use all operators from Airflow 2.0 (airflow.providers package) if you install (backport providers package)(http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/backport-providers.html). We no longer make any changes to the airflow.contrib operators, because in Airflow 2.0 we will move all operators to a airflow.providers and it is possible to install these operators in Airflow 1.10.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-678828823


   The checks are being cancelled because we have not yet ported the recent CI changes to the 1.10 branch. We are going to do that after the 1.10.12 release gets actually released. For now the standard process is to make PRs to master rather than v1-10-stable (that's the standard procedure we follow) - then committers should port it to 1.10 (but after 1.10.12 release you will be able to do it as a PR to v1-10-stable as well). So basically - a little patience. I hope we are going to release 1.10.12 Monday and we will port all the changes to 1.10 as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] stale[bot] commented on pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

stale[bot] commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-706789497


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] syudb commented on pull request #10461: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.

syudb commented on pull request #10461:
URL: https://github.com/apache/airflow/pull/10461#issuecomment-678819988


   Apologies for the noob question but not sure why the checks are getting cancelled, please let me know if there's something I need to fix!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org